Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip nbdkit for all raw/iso image imports #2743

Closed
wants to merge 3 commits into from
Closed

skip nbdkit for all raw/iso image imports #2743

wants to merge 3 commits into from

Conversation

mhenriks
Copy link
Member

@mhenriks mhenriks commented Jun 6, 2023

What this PR does / why we need it:

I don't think there's any benefit to using nbdkit to proxy raw/iso images. At this point, I believe it is mostly useful when "qemu-img convert" is required because the http client in qemu-img has issues.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2737

Special notes for your reviewer:

Release note:

skip nbdkit for all raw/iso image imports

@mhenriks
skip nbdkit for all raw/iso images
7a33d36 
Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jun 6, 2023
@mhenriks
Copy link
Member Author

mhenriks commented Jun 6, 2023

/hold

@kubevirt-bot kubevirt-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S labels Jun 6, 2023
@kubevirt-bot kubevirt-bot requested review from awels and maya-r June 6, 2023 15:19
@mhenriks mhenriks mentioned this pull request Jun 6, 2023
Closed
@awels
Copy link
Member

awels commented Jun 6, 2023

Nice
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2023
@mhenriks
fix func tests
3412313 
Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2023
@mhenriks
Copy link
Member Author

mhenriks commented Jun 7, 2023

/retest-required

@lxs137 lxs137 mentioned this pull request Jun 7, 2023
Closed
@mhenriks
explicitly set preallocated when using golang client to import raw/iso
4b1e4f7 
Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
@mhenriks
Copy link
Member Author

mhenriks commented Jun 8, 2023

/retest-required

1 similar comment
@mhenriks
Copy link
Member Author

mhenriks commented Jun 8, 2023

/retest-required

@awels
Copy link
Member

awels commented Jun 9, 2023

/test pull-containerized-data-importer-e2e-destructive

@awels
Copy link
Member

awels commented Jun 9, 2023

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2023
@awels
Copy link
Member

awels commented Jun 9, 2023

/override pull-containerized-data-importer-e2e-destructive

@kubevirt-bot
Copy link
Contributor

@awels: Overrode contexts on behalf of awels: pull-containerized-data-importer-e2e-destructive

In response to this:

/override pull-containerized-data-importer-e2e-destructive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@awels
Copy link
Member

awels commented Jun 9, 2023

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2023
@ShellyKa13
Copy link
Contributor

should we remove hold?

@alromeros
Copy link
Collaborator

should we remove hold?

Yeah, I think this looks good. @mhenriks wdyt?

@alromeros alromeros mentioned this pull request Aug 11, 2023
Merged
@awels
Copy link
Member

awels commented Aug 11, 2023

Yeah I think we can close this.

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 12, 2023
@kubevirt-bot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 10, 2023
@kubevirt-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@kubevirt-bot kubevirt-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 10, 2023
@alromeros
Copy link
Collaborator

Closing this PR as discussed in #2832, feel free to reopen if necessary!

@alromeros alromeros closed this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awels awels Awaiting requested review from awels

@maya-r maya-r Awaiting requested review from maya-r

Assignees

@awels awels

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTTP Datasource can't handle s3 presigned URL for ISO file
5 participants
@mhenriks @awels @kubevirt-bot @ShellyKa13 @alromeros