Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataVolume Controller uses VolumeCloneSource Populator #2750

Merged
merged 19 commits into from
Jun 29, 2023
Merged

DataVolume Controller uses VolumeCloneSource Populator #2750

merged 19 commits into from
Jun 29, 2023
+1,803 −3,015

Commits on Jun 27, 2023

  1. remove CSI clone 

    bye bye

Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
    @mhenriks
    mhenriks committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    2285ceb View commit details
    Browse the repository at this point in the history

  2. no more smart clone 

    Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
    @mhenriks
    mhenriks committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    1cd82ef View commit details
    Browse the repository at this point in the history

  3. PVC clone same namespace 

    Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
    @mhenriks
    mhenriks committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    f7bc5ef View commit details
    Browse the repository at this point in the history

  4. cross namespace pvc clone 

    Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
    @mhenriks
    mhenriks committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    c5260ae View commit details
    Browse the repository at this point in the history

  5. various fixes to get some functional tests to work 

    Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
    @mhenriks
    mhenriks committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    fbce7ec View commit details
    Browse the repository at this point in the history

  6. delete smart clone controller again 

    somehow reappeared after rebase

Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
    @mhenriks
    mhenriks committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    28f9411 View commit details
    Browse the repository at this point in the history

  7. mostly pvc clone functional test fixes 

    make sure size detect pod only runs on kubevirt content type

clone populator was skipping last round op applying pvc' annotations

various func test fixes

review comments

Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
    @mhenriks
    mhenriks committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    5382013 View commit details
    Browse the repository at this point in the history

  8. more various test fixes 

    host clone phase should (implicitly) wait for clone source pod to exit

Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
    @mhenriks
    mhenriks committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    e77f74c View commit details
    Browse the repository at this point in the history

  9. remove "smart" clone from snapshot 

    Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
    @mhenriks
    mhenriks committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    7e677b2 View commit details
    Browse the repository at this point in the history

  10. DataVolume clone from snapshot uses populator 

    Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
    @mhenriks
    mhenriks committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    525af57 View commit details
    Browse the repository at this point in the history

  11. improve clone populator/datavolume coordination on "running" condition 

    For host clone, not much changes, values still comming from annotations on host clone PVC

For smart/csi clone the DataVolume will be "running" if not in pending or error phase

Will have the same values for terminal "completed" state regardless of clone type

Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
    @mhenriks
    mhenriks committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    fd1beed View commit details
    Browse the repository at this point in the history

  12. unit tests for pvc/snapshot clone controllers 

    Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
    @mhenriks
    mhenriks committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    e6b618f View commit details
    Browse the repository at this point in the history

  13. remove skipped test added in kubevirt#2759 

    Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
    @mhenriks
    mhenriks committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    6e49650 View commit details
    Browse the repository at this point in the history

  14. attempt address AfterSuite and generate-verify failures 

    Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
    @mhenriks
    mhenriks committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    7ca275c View commit details
    Browse the repository at this point in the history

  15. handle snapshot clone with no target size specified 

    also add more validation to some snapshot clone tests

Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
    @mhenriks
    mhenriks committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    c76d2d6 View commit details
    Browse the repository at this point in the history

  16. remove Patch calls 

    Using the controller runtime Patch API with controller runtime cached client seems to be a pretty bad fit

At least given the way the CR API is designed where an old object is compared to new.

I like patch in theory though and will revisit

Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
    @mhenriks
    mhenriks committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    075b7f2 View commit details
    Browse the repository at this point in the history

  17. Clone populator should plan and execute even if PVC is bound 

    It was possible to miss "preallocation applied" annotation otherwise

Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
    @mhenriks
    mhenriks committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    691028e View commit details
    Browse the repository at this point in the history

  18. add long term token to datavolume 

    Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
    @mhenriks
    mhenriks committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    f605718 View commit details
    Browse the repository at this point in the history

  19. Rename ProgressReporter to StatusReporter 

    Should have been done back when annotations were addded to "progress"

Also, if pvc is bound do not call phase Reconcile functions only Status

Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
    @mhenriks
    mhenriks committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    7edeaee View commit details
    Browse the repository at this point in the history