Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable DV GC by default #2754

Merged
merged 4 commits into from
Jun 20, 2023
Merged

Disable DV GC by default #2754

merged 4 commits into from
Jun 20, 2023

Commits on Jun 20, 2023

  1. Disable DV GC by default 

    DataVolume garbage collection is a nice feature, but unfortunately it
violates fundamental principle of Kubernetes. CR should not be
auto-deleted when it completes its role (Job with TTLSecondsAfter-
Finished is an exception), and once CR was created we can assume it is
there until explicitly deleted. In addition, CR should keep idempotency,
so the same CR manifest can be applied multiple times, as long as it is
a valid update (e.g. DataVolume validation webhook does not allow
updating the spec).

When GC is enabled, some systems (e.g GitOps / ArgoCD) may require a
workaround (DV annotation deleteAfterCompletion = "false") to prevent
GC and function correctly.

On the next kubevirt-bot Bump kubevirtci PR (with bump-cdi), it will
fail on all kubevirtci lanes with tests referring DVs, as the tests
IsDataVolumeGC() looks at CDIConfig Spec.DataVolumeTTLSeconds and
assumes default is enabled. This should be fixed there.

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
    @arnongilboa
    arnongilboa committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    c473c20 View commit details
    Browse the repository at this point in the history

  2. Fix test waiting for PVC deletion with UID 

    Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
    @arnongilboa
    arnongilboa committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    c870ac8 View commit details
    Browse the repository at this point in the history

  3. Fix clone test assuming DV was GCed 

    Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
    @arnongilboa
    arnongilboa committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    2aecf35 View commit details
    Browse the repository at this point in the history

  4. Fix DIC controller DV/PVC deletion when snapshot is ready 

    Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
    @arnongilboa
    arnongilboa committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    ab51cfb View commit details
    Browse the repository at this point in the history