Add some debug logs on DataImportCron deletes #2761
Conversation
kubevirt-bot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
akalenyu
force-pushed
the
cron-delete-debugs
branch
from
aaaa0f2
to
78cca00
Compare
|
@akalenyu: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| @@ -822,11 +822,13 @@ func (r *DataImportCronReconciler) garbageCollectPVCs(ctx context.Context, names | |||
| }) | |||
| for _, pvc := range pvcList.Items[maxImports:] { | |||
| dv := cdiv1.DataVolume{ObjectMeta: metav1.ObjectMeta{Name: pvc.Name, Namespace: pvc.Namespace}} | |||
| r.log.V(3).Info("Calling delete on dv", "dv.Name", dv.Name) | |||
There was a problem hiding this comment.
Maybe wait for #2754 to be merged since this code will be slightly modified. Other than that looks good.
There was a problem hiding this comment.
that makes sense to me, maybe close this PR and push those few lines in there?
@arnongilboa
There was a problem hiding this comment.
Added, please check if it lgty. Dropped the annotation.
There was a problem hiding this comment.
I am keeping this PR until we clear up which version GC gets in to
kubevirt-bot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/close |
|
@akalenyu: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
May help identifying potential issue in data import cron controller
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: