Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set clone strategy for ceph to CSI clone #2811

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

akalenyu
Copy link
Collaborator

What this PR does / why we need it:
Per recommendation from ceph CSI team,
switching over to doing CSI clones by default for ceph provisioners. Implementation is very similar to today's smart cloning via temporary snapshot:
https://issues.redhat.com/browse/CNV-28254?focusedId=22318987&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-22318987

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
https://bugzilla.redhat.com/show_bug.cgi?id=2223577

Special notes for your reviewer:

Release note:

Switch ceph provisioners clone strategy to CSI cloning

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S labels Jul 18, 2023
@akalenyu
Copy link
Collaborator Author

/cc @arnongilboa

@arnongilboa
Copy link
Collaborator

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2023
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2023
Per recommendation from ceph CSI team,
switching over to doing CSI clones by default for ceph provisioners.
Implementation is very similar to today's smart cloning via temporary snapshot.

Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
@awels
Copy link
Member

awels commented Jul 25, 2023

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2023
@kubevirt-bot kubevirt-bot merged commit 59dbf30 into kubevirt:main Jul 25, 2023
16 checks passed
@akalenyu
Copy link
Collaborator Author

/cherrypick release-v1.57

@kubevirt-bot
Copy link
Contributor

@akalenyu: new pull request created: #2817

In response to this:

/cherrypick release-v1.57

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants