Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.57] Add documentation for cdi populators #2812

Conversation

kubevirt-bot
Copy link
Contributor

This is an automated cherry-pick of #2776

/assign ShellyKa13

Add documentation for cdi populators

Signed-off-by: Shelly Kagan <skagan@redhat.com>
Signed-off-by: Shelly Kagan <skagan@redhat.com>
@kubevirt-bot kubevirt-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 19, 2023
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jul 19, 2023
@alromeros
Copy link
Collaborator

/lgtm
Just curiosity, any reasons to backport upstream documentation?

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2023
@awels
Copy link
Member

awels commented Jul 19, 2023

I don't mind, but I had the same question
/approve

@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2023
@ShellyKa13
Copy link
Contributor

@alromeros @awels thats also what I asked cause I didn't remember backporting docs, but Jenia raised and requested, I haven't thought of a reason why not, and do see some value which is if someone has the released version locally he will have the documentation and not only on main upstream..

@kubevirt-bot kubevirt-bot merged commit f46544c into kubevirt:release-v1.57 Jul 19, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants