Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always use scratchspace when importing and converting #2832

Merged
merged 7 commits into from
Aug 11, 2023
Merged

Always use scratchspace when importing and converting #2832

merged 7 commits into from
Aug 11, 2023

Commits on Aug 4, 2023

  1. Remove older nbdkit 

    Signed-off-by: Alexander Wels <awels@redhat.com>
    @awels
    awels committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    1210cc1 View commit details
    Browse the repository at this point in the history

  2. When converting always use scratch space importing instead 

    of ndbkit. Once we are able to get nbdkit 1.35.8 or newer
we can revert this change since that will include improvements
to the downloading speed.

Signed-off-by: Alexander Wels <awels@redhat.com>
    @awels
    awels committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    6927bc9 View commit details
    Browse the repository at this point in the history

  3. Disable metrics test for import because straight import doesn't 

    return total, and this means the metrics are disabled.

Signed-off-by: Alexander Wels <awels@redhat.com>
    @awels
    awels committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    b140bb8 View commit details
    Browse the repository at this point in the history

  4. Fix broken functional tests 

    Signed-off-by: Alexander Wels <awels@redhat.com>
    @awels
    awels committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    9496558 View commit details
    Browse the repository at this point in the history

  5. Address review comments 

    Signed-off-by: Alexander Wels <awels@redhat.com>
    @awels
    awels committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    06dec15 View commit details
    Browse the repository at this point in the history

  6. Additional review comments. 

    Fixed functional test that was not doing the right
thing while running the test.

Signed-off-by: Alexander Wels <awels@redhat.com>
    @awels
    awels committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    ba11540 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. Always set preallocation on block devices when directly 

    writing to the device

Signed-off-by: Alexander Wels <awels@redhat.com>
    @awels
    awels committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    5186dcd View commit details
    Browse the repository at this point in the history