[release-v1.57] Always use scratchspace when importing and converting (#2832) #2841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note
* Remove older nbdkit Signed-off-by: Alexander Wels <awels@redhat.com> * When converting always use scratch space importing instead of ndbkit. Once we are able to get nbdkit 1.35.8 or newer we can revert this change since that will include improvements to the downloading speed. Signed-off-by: Alexander Wels <awels@redhat.com> * Disable metrics test for import because straight import doesn't return total, and this means the metrics are disabled. Signed-off-by: Alexander Wels <awels@redhat.com> * Fix broken functional tests Signed-off-by: Alexander Wels <awels@redhat.com> * Address review comments Signed-off-by: Alexander Wels <awels@redhat.com> * Additional review comments. Fixed functional test that was not doing the right thing while running the test. Signed-off-by: Alexander Wels <awels@redhat.com> * Always set preallocation on block devices when directly writing to the device Signed-off-by: Alexander Wels <awels@redhat.com> --------- Signed-off-by: Alexander Wels <awels@redhat.com>
awels
force-pushed
the
always_scratchspace-b
branch
from
a7e4652
to
d7c5a68
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mhenriks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Backport of #2832
Release note: