Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ontap-san to be RWX #2868

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Update ontap-san to be RWX #2868

merged 1 commit into from
Sep 8, 2023

Conversation

awels
Copy link
Member

@awels awels commented Aug 24, 2023

For some reason it was marked RWO instead of RWX.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

BugFix: Trident ontap-san supports RWX not just RWO

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 24, 2023
@awels
Copy link
Member Author

awels commented Aug 24, 2023

/hold
just verifying on real cluster it works

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2023
@arnongilboa
Copy link
Collaborator

@awels verified?

@awels
Copy link
Member Author

awels commented Aug 30, 2023

Not yet, waiting for the cluster that has it to get fixed. I will update once I have confirmation.

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 6, 2023
@awels
Copy link
Member Author

awels commented Sep 6, 2023

Yes verified, just need to fix the conflict.

@awels
Update ontap-san to be RWX
241beaf 
For some reason it was marked RWO instead of RWX.

Signed-off-by: Alexander Wels <awels@redhat.com>
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2023
@awels
Copy link
Member Author

awels commented Sep 8, 2023

/hold cancel

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 8, 2023
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2023
@aglitke
Copy link
Member

aglitke commented Sep 8, 2023

/lgtm

@mhenriks
Copy link
Member

mhenriks commented Sep 8, 2023

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2023
@kubevirt-bot kubevirt-bot merged commit c6089cb into kubevirt:main Sep 8, 2023
18 checks passed
@awels
Copy link
Member Author

awels commented Sep 8, 2023

/cherrypick release-v1.57

@kubevirt-bot
Copy link
Contributor

@awels: new pull request created: #2891

In response to this:

/cherrypick release-v1.57

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot mentioned this pull request Sep 8, 2023
Merged
@awels
Copy link
Member Author

awels commented Sep 8, 2023

/cherrypick release-v1.56

@kubevirt-bot kubevirt-bot mentioned this pull request Sep 8, 2023
Merged
@kubevirt-bot
Copy link
Contributor

@awels: new pull request created: #2892

In response to this:

/cherrypick release-v1.56

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@awels
Copy link
Member Author

awels commented Sep 8, 2023

/cherrypick release-v1.55

@kubevirt-bot
Copy link
Contributor

@awels: new pull request created: #2893

In response to this:

/cherrypick release-v1.55

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot mentioned this pull request Sep 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aglitke aglitke aglitke approved these changes

@alromeros alromeros Awaiting requested review from alromeros

@arnongilboa arnongilboa Awaiting requested review from arnongilboa

Assignees

@aglitke aglitke

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@awels @arnongilboa @aglitke @mhenriks @kubevirt-bot