Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v1.57] Ensure priority class is assigned to pod populating pvc prime #2870

Closed
wants to merge 5 commits into from
Closed

[release-v1.57] Ensure priority class is assigned to pod populating pvc prime #2870

wants to merge 5 commits into from

Conversation

kubevirt-bot
Copy link
Contributor

This is an automated cherry-pick of #2864

/assign awels

BugFix: Fix not passing priority class to populator pod

@awels
Ensure priority class is assigned to pod populating pvc prime
3eb72cc 
Priority class was not being passed to the pvc prime from the PVC
and thus was not being added to the importer pod populating the
pvc prime. There is a list of allowed annotations that can be passed
and the priority class annotation was not in it. This commit adds
the annotation to the allowed list.

Cleaned up unneed log argument to a function related to passing the
annotations.

Signed-off-by: Alexander Wels <awels@redhat.com>
@awels
Restore the logger as it was logging the pvc name as well as the log …
63d1fa6 
…message. Modified the name to make it clearer this is the case.

Signed-off-by: Alexander Wels <awels@redhat.com>
@awels
Have upload also use the populator, can't do clone because the pod di…
435ddf8 
…sappears too quickly without retain

Signed-off-by: Alexander Wels <awels@redhat.com>
@awels
Test for priority class in upload as well as fix typo in cloning test.
0bb860b 
Signed-off-by: Alexander Wels <awels@redhat.com>
@kubevirt-bot kubevirt-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 25, 2023
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Aug 25, 2023
@kubevirt-bot kubevirt-bot mentioned this pull request Aug 25, 2023
Merged
@alromeros
Copy link
Collaborator

/retest

@kubevirt-bot
Copy link
Contributor Author

@kubevirt-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cdi-unit-test 0bb860b link false /test pull-cdi-unit-test
pull-cdi-linter 0bb860b link false /test pull-cdi-linter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@awels
Copy link
Member

awels commented Aug 25, 2023

looks like we need a manual backport, probably due to ginkgov1 vs v2. v2 doesn't need the import for the DescribeTable, while v1 does.

@awels
Update import-populator_test.go
1ab33e6 
Use table import due to 1.57 using ginkgo v1
@kubevirt-bot kubevirt-bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. and removed dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 25, 2023
@kubevirt-bot
Copy link
Contributor Author

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • 1ab33e6 Update import-populator_test.go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from awels. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@awels awels closed this Aug 25, 2023
@alromeros alromeros mentioned this pull request Aug 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awels awels Awaiting requested review from awels

@ShellyKa13 ShellyKa13 Awaiting requested review from ShellyKa13

Assignees

@awels awels

Labels
dco-signoff: no Indicates the PR's author has not DCO signed all their commits. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kubevirt-bot @alromeros @awels