[release-v1.57] Ensure priority class is assigned to pod populating pvc prime #2872
Conversation
…rt#2864) * Ensure priority class is assigned to pod populating pvc prime Priority class was not being passed to the pvc prime from the PVC and thus was not being added to the importer pod populating the pvc prime. There is a list of allowed annotations that can be passed and the priority class annotation was not in it. This commit adds the annotation to the allowed list. Cleaned up unneed log argument to a function related to passing the annotations. Signed-off-by: Alexander Wels <awels@redhat.com> * Restore the logger as it was logging the pvc name as well as the log message. Modified the name to make it clearer this is the case. Signed-off-by: Alexander Wels <awels@redhat.com> * Have upload also use the populator, can't do clone because the pod disappears too quickly without retain Signed-off-by: Alexander Wels <awels@redhat.com> * Test for priority class in upload as well as fix typo in cloning test. Signed-off-by: Alexander Wels <awels@redhat.com> --------- Signed-off-by: Alexander Wels <awels@redhat.com>
Signed-off-by: Alexander Wels <awels@redhat.com>
kubevirt-bot
added
release-note-none
|
/retest-required |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mhenriks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
lgtm
|
/override pull-containerized-data-importer-e2e-ceph-wffc |
|
@awels: Overrode contexts on behalf of awels: pull-containerized-data-importer-e2e-ceph-wffc, pull-containerized-data-importer-e2e-destructive In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override pull-containerized-data-importer-e2e-hpp-latest |
|
@awels: Overrode contexts on behalf of awels: pull-containerized-data-importer-e2e-hpp-latest, pull-containerized-data-importer-e2e-istio, pull-containerized-data-importer-e2e-nfs, pull-containerized-data-importer-e2e-upg, pull-containerized-data-importer-non-csi-hpp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override pull-containerized-data-importer-fossa |
|
@awels: Overrode contexts on behalf of awels: pull-containerized-data-importer-fossa In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Manual backport of #2864
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: