Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.56] Fix Portworx CSI storage capabilities #2897

Merged

Conversation

arnongilboa
Copy link
Collaborator

@arnongilboa arnongilboa commented Sep 14, 2023

Manual backport of #2789

What this PR does / why we need it:
Fix Portworx provisioner capabilities and add preferred ReadWriteMany, Filesystem.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes bz #2237872

Special notes for your reviewer:

Release note:

Fix Portworx provisioner capabilities and add preferred ReadWriteMany, Filesystem.

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 14, 2023
@akalenyu
Copy link
Collaborator

Do we want to maybe sync storagecapabilities.go in this branch with main? Or do they diverge too much?
It can make automatic backports easier for us

@arnongilboa
Copy link
Collaborator Author

arnongilboa commented Sep 14, 2023

Do we want to maybe sync storagecapabilities.go in this branch with main? Or do they diverge too much? It can make automatic backports easier for us

done

Manual backport of kubevirt#2789, plus minor alignments with main branch.

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
@akalenyu
Copy link
Collaborator

thanks!
/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akalenyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2023
@kubevirt-bot kubevirt-bot merged commit 5ff3c92 into kubevirt:release-v1.56 Sep 14, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants