Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v1.57] Fix possible nil ptr in snapshot/pvc clone controllers #2905

Merged
merged 1 commit into from
Sep 22, 2023
Merged

[release-v1.57] Fix possible nil ptr in snapshot/pvc clone controllers #2905

merged 1 commit into from
Sep 22, 2023

Conversation

kubevirt-bot
Copy link
Contributor

This is an automated cherry-pick of #2900

/assign akalenyu

BugFix: nil ptr in snapshot clone controller

@akalenyu
Fix possible nil ptr in snapshot/pvc clone controllers
cdda64c 
We slap on the clone-without-source index key regardless of source.PVC/source.Snapshot so
it was possible for a DV with PVC source to get queued for the snapshot controller
(and hence the nil ptr).

The test addition demonstrates a real use case where this would happen.

Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 21, 2023
@kubevirt-bot kubevirt-bot mentioned this pull request Sep 21, 2023
Merged
@awels
Copy link
Member

awels commented Sep 21, 2023

/test pull-containerized-data-importer-e2e-ceph

@awels
Copy link
Member

awels commented Sep 21, 2023

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2023
@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2023
@awels
Copy link
Member

awels commented Sep 22, 2023

/override pull-containerized-data-importer-e2e-ceph

@kubevirt-bot
Copy link
Contributor Author

@awels: Overrode contexts on behalf of awels: pull-containerized-data-importer-e2e-ceph

In response to this:

/override pull-containerized-data-importer-e2e-ceph

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot merged commit 7552fad into kubevirt:release-v1.57 Sep 22, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnongilboa arnongilboa Awaiting requested review from arnongilboa

@mhenriks mhenriks Awaiting requested review from mhenriks

Assignees

@awels awels

@akalenyu akalenyu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kubevirt-bot @awels @akalenyu