Move clone_progress to separate list #2929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note
avlitman
force-pushed
the
move-internal-metric
branch
from
32a02e8
to
25ca444
Compare
avlitman
changed the title
Since clone_progress metric used for internal purpose only we should not document it in metrics.md or test it in the metrics linter. therefore clone_progress moved to separate list (not used by the doc and linter generators). Signed-off-by: Aviv Litman <alitman@alitman-thinkpadp1gen4i.tlv.csb>
avlitman
force-pushed
the
move-internal-metric
branch
from
25ca444
to
ab4de1f
Compare
sradco
reviewed
Oct 18, 2023
|
/retest |
|
Please do not merge this PR before @sradco approves. |
|
/hold waiting on @sradco to review |
kubevirt-bot
added
the
do-not-merge/hold
|
/lgtm |
kubevirt-bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awels The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Since clone_progress metric used for internal purpose only we should not document it in metrics.md or test it in the metrics linter. therefore clone_progress moved to separate list (not used by the doc and linter generators).
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2515
Jira-ticket: https://issues.redhat.com/browse/CNV-33647
Special notes for your reviewer:
This fix was discussed with CDI developer.
Release note: