-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version field to the OpenAPI definition #2973
Conversation
Signed-off-by: Denis Ollier <dollierp@redhat.com>
33a4349
to
1472810
Compare
1472810
to
557ccab
Compare
/lgtm |
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mhenriks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/test pull-containerized-data-importer-e2e-upg |
/retest |
/cherrypick release-v1.58 |
@akalenyu: new pull request created: #3014 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This missing field is reported by ZAP when trying to discover the CDI API:
error: attribute info.version is missing
.Adding this field makes ZAP happy and the scan can proceed.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes https://issues.redhat.com/browse/CNV-34683
Special notes for your reviewer:
I copied KubeVirt implementation (https://github.com/kubevirt/kubevirt/blob/5d8c225/pkg/virt-api/api.go#L728)
Release note: