Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version field to the OpenAPI definition #2973

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

dollierp
Copy link
Contributor

@dollierp dollierp commented Nov 8, 2023

What this PR does / why we need it:
This missing field is reported by ZAP when trying to discover the CDI API: error: attribute info.version is missing.

Adding this field makes ZAP happy and the scan can proceed.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes https://issues.redhat.com/browse/CNV-34683

Special notes for your reviewer:

I copied KubeVirt implementation (https://github.com/kubevirt/kubevirt/blob/5d8c225/pkg/virt-api/api.go#L728)

Release note:

NONE

Signed-off-by: Denis Ollier <dollierp@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: no Indicates the PR's author has not DCO signed all their commits. size/XS labels Nov 8, 2023
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Nov 8, 2023
@akalenyu
Copy link
Collaborator

akalenyu commented Nov 8, 2023

/lgtm
/cc @mhenriks
does it make sense to include the version in api/openapi-spec/swagger.json?

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2023
@dollierp
Copy link
Contributor Author

dollierp commented Nov 9, 2023

/retest

@mhenriks
Copy link
Member

mhenriks commented Nov 9, 2023

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2023
@akalenyu
Copy link
Collaborator

/retest

@akalenyu
Copy link
Collaborator

/test pull-containerized-data-importer-e2e-upg

@dollierp
Copy link
Contributor Author

/retest

@kubevirt-bot kubevirt-bot merged commit 7dec9f4 into kubevirt:main Nov 13, 2023
21 checks passed
@dollierp dollierp deleted the openapi-version branch November 13, 2023 21:36
@akalenyu
Copy link
Collaborator

/cherrypick release-v1.58

@kubevirt-bot
Copy link
Contributor

@akalenyu: new pull request created: #3014

In response to this:

/cherrypick release-v1.58

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants