Grant ns admin missing create RBAC for various CDI resources #3030
Conversation
Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
kubevirt-bot
added
release-note
|
/lgtm |
There was a problem hiding this comment.
/approve
This fixes the immediate problem, but doesn't catch any future missing items. Not entirely sure how we would catch them though. Maybe we can somehow find all the CRDs owned by the operator, and check if the admin user has access. If not then fail the test?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awels The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
Could we backport this to 1.57 please? |
|
/cherrypick release-v1.58 |
|
@awels: once the present PR merges, I will cherry-pick it on top of release-v1.58 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Do we have the appropriate issues for the backports? |
|
/cherrypick release-v1.57 |
|
@awels: once the present PR merges, I will cherry-pick it on top of release-v1.57 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@awels: new pull request created: #3031 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@awels: new pull request created: #3032 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-v1.56 |
|
@akalenyu: new pull request created: #3137 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-v1.55 |
|
@akalenyu: new pull request created: #3138 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Currently a (non-cluster-admin) namespace admin cannot create various CDI user-facing resources,
this PR grants the missing permissions.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
https://issues.redhat.com/browse/CNV-36309
Special notes for your reviewer:
Release note: