-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flakiness in waitForStorageProfileMetricInit #3038
Conversation
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akalenyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/hold |
/test pull-containerized-data-importer-e2e-destructive |
If CDI CR was deleted and re-created, the metric may have old instances of the old cdi-deployment pod IP. Also added alerts Polarion test_ids and restore ginkgo output verbosity. Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
135926a
to
bcb91cf
Compare
/test pull-containerized-data-importer-e2e-destructive |
/lgtm |
/test pull-containerized-data-importer-e2e-ceph-wffc |
/test pull-containerized-data-importer-e2e-destructive |
Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
/test pull-containerized-data-importer-non-csi-hpp |
/hold |
/lgtm |
Manual backport of kubevirt#2998 & kubevirt#3038 - CDINoDefaultStorageClass - not having a default (or virt default) SC is surely not an OpenShift error, as admins may prefer their cluster users to only use explicit SC names. However, in the CDI context when DV is created with default SC but default does not exist, we will fire an error event and the PVC will be Pending for the default SC, so when there are such Pending PVCs we will fire an alert. - CDIDefaultStorageClassDegraded - when the default (or virt default) SC does not support CSI/Snapshot clone (smart clone) or does not have ReadWriteMany access mode (for live migration). - CDIStorageProfilesIncomplete - add storageClass and provisioner labels. - CDIDataImportCronOutdated - add dataImportCron namespace and name labels. Also: * Rename the metric kubevirt_cdi_storageprofile_status to kubevirt_cdi_storageprofile_info since it always reports value 1, where the label values provide the details about the storage class and storage profile. * Add snapshot manifests for tests and deploy snapshot CRDs in the hpp destructive lane Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
Manual backport of kubevirt#2998 & kubevirt#3038 - CDINoDefaultStorageClass - not having a default (or virt default) SC is surely not an OpenShift error, as admins may prefer their cluster users to only use explicit SC names. However, in the CDI context when DV is created with default SC but default does not exist, we will fire an error event and the PVC will be Pending for the default SC, so when there are such Pending PVCs we will fire an alert. - CDIDefaultStorageClassDegraded - when the default (or virt default) SC does not support CSI/Snapshot clone (smart clone) or does not have ReadWriteMany access mode (for live migration). - CDIStorageProfilesIncomplete - add storageClass and provisioner labels. - CDIDataImportCronOutdated - add dataImportCron namespace and name labels. Also: * Rename the metric kubevirt_cdi_storageprofile_status to kubevirt_cdi_storageprofile_info since it always reports value 1, where the label values provide the details about the storage class and storage profile. * Add snapshot manifests for tests and deploy snapshot CRDs in the hpp destructive lane Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
…3040) Manual backport of #2998 & #3038 - CDINoDefaultStorageClass - not having a default (or virt default) SC is surely not an OpenShift error, as admins may prefer their cluster users to only use explicit SC names. However, in the CDI context when DV is created with default SC but default does not exist, we will fire an error event and the PVC will be Pending for the default SC, so when there are such Pending PVCs we will fire an alert. - CDIDefaultStorageClassDegraded - when the default (or virt default) SC does not support CSI/Snapshot clone (smart clone) or does not have ReadWriteMany access mode (for live migration). - CDIStorageProfilesIncomplete - add storageClass and provisioner labels. - CDIDataImportCronOutdated - add dataImportCron namespace and name labels. Also: * Rename the metric kubevirt_cdi_storageprofile_status to kubevirt_cdi_storageprofile_info since it always reports value 1, where the label values provide the details about the storage class and storage profile. * Add snapshot manifests for tests and deploy snapshot CRDs in the hpp destructive lane Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
Manual backport of kubevirt#2998 & kubevirt#3038 - CDINoDefaultStorageClass - not having a default SC is surely not an OpenShift error, as admins may prefer their cluster users to only use explicit SC names. However, in the CDI context when DV is created with default SC but default does not exist, we will fire an error event and the PVC will be Pending for the default SC, so when there are such Pending PVCs we will fire an alert. - CDIDefaultStorageClassDegraded - when the default SC does not support CSI/Snapshot clone (smart clone) or does not have ReadWriteMany access mode (for live migration). - CDIStorageProfilesIncomplete - add storageClass and provisioner labels. - CDIDataImportCronOutdated - add dataImportCron namespace and name labels. Also: * Rename the metric kubevirt_cdi_storageprofile_status to kubevirt_cdi_storageprofile_info since it always reports value 1, where the label values provide the details about the storage class and storage profile. * Add snapshot manifests for tests and deploy snapshot CRDs in the hpp destructive lane Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
…3041) Manual backport of #2998 & #3038 - CDINoDefaultStorageClass - not having a default SC is surely not an OpenShift error, as admins may prefer their cluster users to only use explicit SC names. However, in the CDI context when DV is created with default SC but default does not exist, we will fire an error event and the PVC will be Pending for the default SC, so when there are such Pending PVCs we will fire an alert. - CDIDefaultStorageClassDegraded - when the default SC does not support CSI/Snapshot clone (smart clone) or does not have ReadWriteMany access mode (for live migration). - CDIStorageProfilesIncomplete - add storageClass and provisioner labels. - CDIDataImportCronOutdated - add dataImportCron namespace and name labels. Also: * Rename the metric kubevirt_cdi_storageprofile_status to kubevirt_cdi_storageprofile_info since it always reports value 1, where the label values provide the details about the storage class and storage profile. * Add snapshot manifests for tests and deploy snapshot CRDs in the hpp destructive lane Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
* Fix flakiness in waitForStorageProfileMetricInit If CDI CR was deleted and re-created, the metric may have old instances of the old cdi-deployment pod IP. Also added alerts Polarion test_ids and restore ginkgo output verbosity. Signed-off-by: Arnon Gilboa <agilboa@redhat.com> * Fix pods_high_restart metrics to be 0 when no pods Signed-off-by: Arnon Gilboa <agilboa@redhat.com> --------- Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
What this PR does / why we need it:
If CDI CR was deleted and re-created, the metric may have old instances of the old cdi-deployment pod IP.
Also added alerts Polarion test_ids and restore ginkgo output verbosity.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: