Stop skipping advanced clone method tests with immediate bind annotation #3039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Smart/CSI clone These tests are by definition only running on CSI storage (IsCSIVolumeCloneStorageClassAvailable/IsSnapshotStorageClassAvailable) - Snapshot clone This test is always getting skipped, since snapshots always imply the storage is CSI Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
kubevirt-bot
added
release-note-none
|
/cc @ShellyKa13 |
arnongilboa
reviewed
Dec 21, 2023
Comment on lines
-2825
to
-2831
| By("Check host assisted clone is taking place") | ||
| pvc, err := f.K8sClient.CoreV1().PersistentVolumeClaims(dataVolume.Namespace).Get(context.TODO(), dataVolume.Name, metav1.GetOptions{}) | ||
| Expect(err).ToNot(HaveOccurred()) | ||
| suffix := "-host-assisted-source-pvc" | ||
| Expect(pvc.Annotations[controller.AnnCloneRequest]).To(HaveSuffix(suffix)) | ||
| Expect(pvc.Spec.DataSource).To(BeNil()) | ||
| Expect(pvc.Spec.DataSourceRef).To(BeNil()) |
There was a problem hiding this comment.
we no longer fall back to host assisted - #2765
so now this test is just about the result being a success
|
/lgtm |
akalenyu
changed the title
|
/test all |
|
/retest |
|
/test all |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awels The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
These tests are by definition only running on CSI storage (IsCSIVolumeCloneStorageClassAvailable/IsSnapshotStorageClassAvailable)
This test is always getting skipped, since snapshots always imply the storage is CSI
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: