[release-v1.58] Fix populators not repopulating pvc after it was deleted #3071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shelly Kagan <skagan@redhat.com>
In case someone deleted the pvc a new pvc is created and the status of the dv is still succeded. when using populators in order for the population to restart and the dv state to change accordingly we need to retrigger the population, this depends on the existing of the source CR. That CR should exist as long as the pvc pod state is not succeeded. When the pvc is recreated the succeded pod state annotation was removed. Adjusted UT accordingly Signed-off-by: Shelly Kagan <skagan@redhat.com>
Move cloner test to a parallel test suite. Simplify import test. Signed-off-by: Shelly Kagan <skagan@redhat.com>
kubevirt-bot
added
release-note-none
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awels The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #3056
/assign ShellyKa13