[release-v1.58] Suppress alerts to reduce noise of dependent ones #3181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manual backport of kubevirt#3129 This is a follow-up to kubevirt#2998 introducing the following changes to alert rules: - CDIDefaultStorageClassDegraded - do not fire when no default SC (either k8s or virt). - CDIDataImportCronOutdated - do not fire when no default SC (either k8s or virt), as DIC import DVs use default SC. - CDINoDefaultStorageClass - fire not only when there is a pending DV (and PVC) but also when DV has an empty status (waiting for default SC etc.) Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
Manual backport of kubevirt#3128 It's time to get the storage capabilities for all no-provisioner storage classes based on the existing PVs, and not only for those labeled with `local.storage.openshift.io/owner-name`, as done so far. It will also silence the unnecessary CDIStorageProfilesIncomplete alert for local SC in the CI. Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
kubevirt-bot
added
the
release-note
kubevirt-bot
added
the
dco-signoff: yes
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akalenyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
arnongilboa
added a commit
to arnongilboa/containerized-data-importer
that referenced
this pull request
May 2, 2024
Somehow dropped from the manual backport due to monitoring refactoring. Missed by CI since it does not run the destructive lane where the CDIDefaultStorageClassDegraded alert is tested [test_id:10720]. The kubevirt_cdi_dataimportcron_outdated utest does not check the actual CDIDataImportCronOutdated alert but only the metric and labels, as decided in order to save CI time. Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
kubevirt-bot
pushed a commit
that referenced
this pull request
May 3, 2024
Somehow dropped from the manual backport due to monitoring refactoring. Missed by CI since it does not run the destructive lane where the CDIDefaultStorageClassDegraded alert is tested [test_id:10720]. The kubevirt_cdi_dataimportcron_outdated utest does not check the actual CDIDataImportCronOutdated alert but only the metric and labels, as decided in order to save CI time. Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Manual backport of #3129 and #3128
Which issue(s) this PR fixes:
Fixes # https://issues.redhat.com/browse/CNV-38918
Special notes for your reviewer:
Release note: