Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve usability of Golangci-lint #3193

Merged
merged 9 commits into from
May 11, 2024
Merged

Improve usability of Golangci-lint #3193

merged 9 commits into from
May 11, 2024

Commits on May 6, 2024

  1. Run 'make format && make generate' 

    Seems like this hadn't been run in a long while.

Signed-off-by: Edu Gómez Escandell <egomez@redhat.com>
    @EduardGomezEscandell
    EduardGomezEscandell committed May 6, 2024
    Configuration menu
    Copy the full SHA
    0881bfd View commit details
    Browse the repository at this point in the history

  2. Run 'golangci-lint --fix' when using 'make format' 

    Signed-off-by: Edu Gómez Escandell <egomez@redhat.com>
    @EduardGomezEscandell
    EduardGomezEscandell committed May 6, 2024
    Configuration menu
    Copy the full SHA
    e2ad069 View commit details
    Browse the repository at this point in the history

  3. Update golangci-lint version 

    Signed-off-by: Edu Gómez Escandell <egomez@redhat.com>
    @EduardGomezEscandell
    EduardGomezEscandell committed May 6, 2024
    Configuration menu
    Copy the full SHA
    ba12ff2 View commit details
    Browse the repository at this point in the history

  4. Remove gofmt 

    Golangci-lint already runs gofmt internally (see ./.golangci.yml)

Signed-off-by: Edu Gómez Escandell <egomez@redhat.com>
    @EduardGomezEscandell
    EduardGomezEscandell committed May 6, 2024
    Configuration menu
    Copy the full SHA
    14ca05c View commit details
    Browse the repository at this point in the history

  5. Remove golint pass 

    This linter has been deprecated since May 9, 2021. Golangci-lint already
covers its functionality

Signed-off-by: Edu Gómez Escandell <egomez@redhat.com>
    @EduardGomezEscandell
    EduardGomezEscandell committed May 6, 2024
    Configuration menu
    Copy the full SHA
    20f6a6c View commit details
    Browse the repository at this point in the history

  6. Remove goimports 

    Golangci-lint already runs goimports internally (see ./.golangci.yml)

Signed-off-by: Edu Gómez Escandell <egomez@redhat.com>
    @EduardGomezEscandell
    EduardGomezEscandell committed May 6, 2024
    Configuration menu
    Copy the full SHA
    0ef0ada View commit details
    Browse the repository at this point in the history

  7. Move govet into golangci-lint 

    This way we don't parse the project twice.

Signed-off-by: Edu Gómez Escandell <egomez@redhat.com>
    @EduardGomezEscandell
    EduardGomezEscandell committed May 6, 2024
    Configuration menu
    Copy the full SHA
    9026891 View commit details
    Browse the repository at this point in the history

  8. Update README 

    Signed-off-by: Edu Gómez Escandell <egomez@redhat.com>
    @EduardGomezEscandell
    EduardGomezEscandell committed May 6, 2024
    Configuration menu
    Copy the full SHA
    77d673b View commit details
    Browse the repository at this point in the history

  9. Run formaters and generators again 

    Signed-off-by: Edu Gómez Escandell <egomez@redhat.com>
    @EduardGomezEscandell
    EduardGomezEscandell committed May 6, 2024
    Configuration menu
    Copy the full SHA
    1cdb8ce View commit details
    Browse the repository at this point in the history