Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update builder to use golang 1.22.3 #3246

Merged
merged 2 commits into from
May 8, 2024

Conversation

akalenyu
Copy link
Collaborator

@akalenyu akalenyu commented May 6, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3226

Special notes for your reviewer:

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 6, 2024
@akalenyu
Copy link
Collaborator Author

akalenyu commented May 6, 2024

/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2024
@akalenyu
Copy link
Collaborator Author

akalenyu commented May 6, 2024

/hold cancel
/cc @awels

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2024
@EduardGomezEscandell
Copy link
Collaborator

Go 1.22.3 is coming out later today with a security fix (CVE-2024-24787), we may want to wait for a day just to get it in.

@akalenyu
Copy link
Collaborator Author

akalenyu commented May 7, 2024

Go 1.22.3 is coming out later today with a security fix (CVE-2024-24787), we may want to wait for a day just to get it in.

Sure
/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2024
Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
Avoid make generate panic:
kubernetes-sigs/controller-tools#888

Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
@akalenyu akalenyu changed the title Update builder to use golang 1.22.2 Update builder to use golang 1.22.3 May 7, 2024
@akalenyu
Copy link
Collaborator Author

akalenyu commented May 7, 2024

/hold cancel

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2024
@mhenriks
Copy link
Member

mhenriks commented May 8, 2024

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2024
@akalenyu
Copy link
Collaborator Author

akalenyu commented May 8, 2024

/test pull-containerized-data-importer-e2e-hpp-previous

@kubevirt-bot kubevirt-bot merged commit 60b5fa4 into kubevirt:main May 8, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prlimit Unit Test fail on s390x with go1.21.5
4 participants