[release-v1.59] Forklift controller #3261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…row/go/src/github.com/kubevirt/project-infra/../containerized-data-importer/WORKSPACE -dry-run=false (kubevirt#3247) Signed-off-by: kubevirt-bot <kubevirtbot@redhat.com>
* Run 'make format && make generate' Seems like this hadn't been run in a long while. Signed-off-by: Edu Gómez Escandell <egomez@redhat.com> * Run 'golangci-lint --fix' when using 'make format' Signed-off-by: Edu Gómez Escandell <egomez@redhat.com> * Update golangci-lint version Signed-off-by: Edu Gómez Escandell <egomez@redhat.com> * Remove gofmt Golangci-lint already runs gofmt internally (see ./.golangci.yml) Signed-off-by: Edu Gómez Escandell <egomez@redhat.com> * Remove golint pass This linter has been deprecated since May 9, 2021. Golangci-lint already covers its functionality Signed-off-by: Edu Gómez Escandell <egomez@redhat.com> * Remove goimports Golangci-lint already runs goimports internally (see ./.golangci.yml) Signed-off-by: Edu Gómez Escandell <egomez@redhat.com> * Move govet into golangci-lint This way we don't parse the project twice. Signed-off-by: Edu Gómez Escandell <egomez@redhat.com> * Update README Signed-off-by: Edu Gómez Escandell <egomez@redhat.com> * Run formaters and generators again Signed-off-by: Edu Gómez Escandell <egomez@redhat.com> --------- Signed-off-by: Edu Gómez Escandell <egomez@redhat.com>
* forklift: add types for forklift populators Introduce the OvirtVolumePopulator and OpenstackVolumePopulator types Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com> * forklift: introduce forklift controller Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com> * forklift: add CRD missing CRD suffix Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com> * forklift: fix tests Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com> * forklift: start support for mutated PVC Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com> * forklift: fix linter issues and skip bound PVCs Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com> * forklift: update vendor and generated code Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com> * forklift: remove unnecessary argument Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com> * forklift: add ovirt-populator to cdi-importer Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com> * forklift: fix linter issues Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com> * forklift: fix contrller_test Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com> * forklift: regenerate swagger Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com> * forklift: normalize ovirt image name Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com> * forklift: restore OVIRT_POPULATOR_IMAGE_NAME Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com> * forklift: address comments - remove accidental copy-paste - change type of NAD reference to string - use NAD in the controller Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com> * forklift: add doc with examples for the forklift populators Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com> * forklift: rename secret reference Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com> * forklift: fix linter warning Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com> * forklift: update deps Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com> * forklift: fix linter issues Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com> * forklift: use ginkgo for openstack populator test Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com> * Roll back nginx from 1.24.0 to 1.22.1 to avoid segfaults when pulling… … images with tls Possibly a bug, there were some segfault fixes in 1.25.4 release: https://nginx.org/en/CHANGES Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com> * forklift: address comments - Fix const - Reverse conditional - Pass context to reconcile - Improve cross namespace check - Add populator pod watcher Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com> * forklift: address comments - Drop unnecessary comments - Add dataSourceRef check - Add node to spec Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com> * forklift: add restartCount annotation - fix race condition leaving Running phase in annotation - fix metrics UT Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com> * forklift: address comments - Change optional fields to a pointer - Fix Pod watch - Add NotFound check to avoid an extra reconile Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com> * forklift: regenerate Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com> --------- Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com> Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com> Co-authored-by: Alex Kalenyuk <akalenyu@redhat.com>
kubevirt-bot
added
release-note
…row/go/src/github.com/kubevirt/project-infra/../containerized-data-importer/WORKSPACE -dry-run=false Signed-off-by: kubevirt-bot <kubevirtbot@redhat.com>
|
/retest |
|
@akalenyu: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awels The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Manual backport of #2983
with some extra main commits that should have no business logic changes.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
https://issues.redhat.com/browse/CNV-41772
Special notes for your reviewer:
Release note: