Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to k8s 1.29 libs #3269

Closed
wants to merge 6 commits into from
Closed

Update to k8s 1.29 libs #3269

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
78349cc
Update libs (soes not compile)
mhenriks May 17, 2024
a7015f2
ReourceRequirements -> VolumeResourceRequirements
mhenriks May 17, 2024
69dfa44
Fix errors with actual openshift/library-go lib
mhenriks May 17, 2024
596f3e4
make generate
mhenriks May 17, 2024
d70e53b
fix "make all"
mhenriks May 17, 2024
fd3f643
fix transfer unit tests
mhenriks May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hack/build/bazel-build-images.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,5 +31,5 @@ for tag in ${docker_tag}; do
--define container_prefix=${docker_prefix} \
--define container_tag=${tag} \
--host_force_python=PY3 \
//:test-container-images //cmd/cdi-operator:cdi-operator-image //cmd/cdi-controller:cdi-controller-image //cmd/cdi-apiserver:cdi-apiserver-image //cmd/cdi-cloner:cdi-cloner-image //cmd/cdi-importer:cdi-importer-image //cmd/cdi-uploadproxy:cdi-uploadproxy-image //cmd/cdi-uploadserver:cdi-uploadserver-image //cmd/ovirt-populator:ovirt-populator-image
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how come this fails? are we really okay with removing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"make all" is broken without it. Remnant of forklift pr. There is a bogus target listed there

//:test-container-images //cmd/cdi-operator:cdi-operator-image //cmd/cdi-controller:cdi-controller-image //cmd/cdi-apiserver:cdi-apiserver-image //cmd/cdi-cloner:cdi-cloner-image //cmd/cdi-importer:cdi-importer-image //cmd/cdi-uploadproxy:cdi-uploadproxy-image //cmd/cdi-uploadserver:cdi-uploadserver-image
done