fix dataStream reader and test bugs #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
jeffvance
changed the title
mhenriks
approved these changes
Aug 15, 2018
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #324
One of the dataStream unit tests called
constructReaderstwice per dataStream. Instead, that test now tests that the number of readers in the Readers slice matches the expected size.Also,
constructReadersnow exits itsforloop once a qcow2 file header is detected. Previously, the loop did an extra (unnecessary) iteration resulting in an additional multi-reader being appended to the Readers slice.@copejon @screeley44 @mhenriks