Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.61] Watch for StorageProfile updates to reconcile DataVolumes #3562

Conversation

kubevirt-bot
Copy link
Contributor

This is an automated cherry-pick of #3547

/assign arnongilboa

Watch for StorageProfile updates to reconcile DataVolumes

Currently, completing an incomplete StorageProfile does not reconcile
the relevant incomplete DVs waiting fro it, unlike the case of missing
StorageClass.

Even after updating the StorageProfile claimPropertySets to have
relevant AccessMode and VolumeMode, the DV is stuck with incomplete
AccessMode and VolumeMode until its exponential back-off reconcile, or
until it's manually updated (e.g. annotated) and reconciled.

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
@kubevirt-bot kubevirt-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 10, 2024
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Dec 10, 2024
@awels
Copy link
Member

awels commented Dec 12, 2024

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2024
@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2024
@kubevirt-bot kubevirt-bot merged commit 1ca24be into kubevirt:release-v1.61 Dec 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants