-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump sigs.k8s.io/controller-runtime to 16.3 #25
Conversation
…perator Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
This reverts commit 69b30de. Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
// src := args.mockController.WatchCalls[0].Src | ||
// // kind, ok := src.(*source.Kind) | ||
// // Expect(ok).To(BeTrue()) | ||
// // Expect(kind.Type).To(BeAssignableToTypeOf(&testcr.Config{})) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these leftovers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah should find a way to keep testing this
@@ -609,10 +608,12 @@ var _ = Describe("Reconciler", func() { | |||
//Modify CRD to be of previousVersion | |||
_ = args.reconciler.CrSetVersion(args.config, prevVersion) | |||
//mark CR for deletion | |||
args.config.SetDeletionTimestamp(&metav1.Time{Time: time.Now()}) | |||
// args.config.SetDeletionTimestamp(&metav1.Time{Time: time.Now()}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leftovers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup
getCfg := func() cache.Cache { | ||
return nil | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
getCache := func() cache.Cache {
return nil
}
Cache: cache.Options{ | ||
DefaultNamespaces: map[string]cache.Config{ | ||
namespace: {}, | ||
}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not nil?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wdym? this is needed to keep the behavior the same as before (Namespace: namespace
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind you are right.
pkg/sdk/reconciler/reconciler.go
Outdated
@@ -566,7 +567,7 @@ func (r *Reconciler) WatchResourceTypes(resources ...client.Object) error { | |||
predicates := []predicate.Predicate{sdk.NewIgnoreLeaderElectionPredicate()} | |||
|
|||
if err := r.controller.Watch(source.Kind(r.getCache(), resource), eventHandler, predicates...); err != nil { | |||
if meta.IsNoMatchError(err) { | |||
if meta.IsNoMatchError(err) || strings.Contains(err.Error(), "failed to find API group") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would love if we could not do this :( kubernetes-sigs/controller-runtime#2425 (comment)
I think it looks great overall, but I left some comments, mostly nits. |
@mhenriks can you please take a look? |
Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
5db2a80
to
2b7aebd
Compare
@Barakmor1 @vladikr @mhenriks PTAL 🙏 |
/release-note-none |
/lgtm |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akalenyu, mhenriks The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Commits are a mess. Will try to restructure