Skip to content

Commit

Permalink
Fix bug where installing HCO on kubernetes+OLM (#2705)
Browse files Browse the repository at this point in the history
In this case, we miss the CSV, as HCO currenlty only read it on
openshift. That eventually causes nil pointer error, and the HCO pod is
in crash loop.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
Co-authored-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
  • Loading branch information
kubevirt-bot and nunnatsa committed Dec 31, 2023
1 parent d23ea5b commit ef6081e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pkg/util/own_resources.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ func findOwnResources(ctx context.Context, cl client.Reader, logger logr.Logger)
logger.Error(err, "Can't get deployment")
return
}
if GetClusterInfo().IsOpenshift() {
if GetClusterInfo().IsManagedByOLM() {
var err error
or.csv, err = getCSVFromDeployment(or.deployment, cl, operatorNs, logger)
if err != nil {
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit ef6081e

Please sign in to comment.