Remove controller-runtime dependency from api package #1483

erkanerol · 2021-08-17T12:09:26Z

Because of webhook codes, we have a dependency on
contoller-runtime in our api package. Api packages should
be as clean as possible. Also, we are hitting an issue*
in test when we try to consume our api package because of
this dependency.

flag redefined: kubeconfig: allow double vendoring this library but still register flags on behalf of users kubernetes-sigs/controller-runtime#878

Signed-off-by: Erkan Erol eerol@redhat.com

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

Release note:

NONE

coveralls · 2021-08-17T12:13:38Z

Pull Request Test Coverage Report for Build 1170074672

71 of 133 (53.38%) changed or added relevant lines in 4 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.5%) to 70.908%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/hco/v1beta1/hyperconverged_webhook.go	0	1	0.0%
pkg/webhooks/setup.go	0	61	0.0%

Files with Coverage Reduction	New Missed Lines	%
pkg/apis/hco/v1beta1/hyperconverged_webhook.go	3	0%

Totals
Change from base Build 1167327466:	0.5%
Covered Lines:	3266
Relevant Lines:	4606

💛 - Coveralls

hco-bot · 2021-08-17T13:26:39Z

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

kubevirt-bot · 2021-08-17T13:26:42Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-08-17T15:26:30Z

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

kubevirt-bot · 2021-08-17T15:26:32Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp

In response to this:

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-08-23T11:41:00Z

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

kubevirt-bot · 2021-08-23T11:41:03Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-08-23T11:51:23Z

okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-gcp

kubevirt-bot · 2021-08-23T11:51:25Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-image-index-gcp

In response to this:

okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-08-23T12:36:35Z

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure

kubevirt-bot · 2021-08-23T12:36:37Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-08-23T13:27:00Z

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

kubevirt-bot · 2021-08-23T13:27:02Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp

In response to this:

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa

Looks very good. Added 3 comments, that are actually the same: use a "constructor" (New... function) to instantiate the whHandler and the nsMutator.

pkg/webhooks/mutator/mutator.go

pkg/webhooks/setup.go

Because of webhook codes, we have a dependency on contoller-runtime in our api package. Api packages should be as clean as possible. Also, we are hitting an issue* in test when we try to consume our api package because of this dependency. * kubernetes-sigs/controller-runtime#878 Signed-off-by: Erkan Erol <eerol@redhat.com>

sonarcloud · 2021-08-26T10:38:34Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

hco-bot · 2021-08-26T11:58:30Z

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

kubevirt-bot · 2021-08-26T11:58:33Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-08-26T12:34:49Z

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure
okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp

kubevirt-bot · 2021-08-26T12:34:52Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure, ci/prow/okd-hco-e2e-upgrade-index-gcp

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure
okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa · 2021-08-26T12:37:39Z

/retest

nunnatsa

/approve

kubevirt-bot · 2021-08-26T12:42:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [nunnatsa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

nunnatsa · 2021-08-26T13:01:38Z

/test hco-e2e-kv-smoke-azure

kubevirt-bot · 2021-08-26T13:01:41Z

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.19
/test pull-hyperconverged-cluster-operator-e2e-k8s-1.20
/test pull-hyperconverged-cluster-operator-e2e-k8s-1.21

Use /test all to run all jobs.

In response to this:

/test hco-e2e-kv-smoke-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-08-26T13:47:21Z

@erkanerol: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
ci/prow/hco-e2e-image-index-gcp	`526252c`	link	`/test hco-e2e-image-index-gcp`
ci/prow/okd-hco-e2e-upgrade-index-gcp	`526252c`	link	`/test okd-hco-e2e-upgrade-index-gcp`
ci/prow/hco-e2e-image-index-azure	`526252c`	link	`/test hco-e2e-image-index-azure`
ci/prow/hco-e2e-kv-smoke-gcp	`526252c`	link	`/test hco-e2e-kv-smoke-gcp`
ci/prow/hco-e2e-upgrade-prev-index-azure	`526252c`	link	`/test hco-e2e-upgrade-prev-index-azure`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

hco-bot · 2021-08-26T13:55:49Z

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

kubevirt-bot · 2021-08-26T13:55:59Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-azure

In response to this:

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-08-26T15:24:38Z

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

kubevirt-bot · 2021-08-26T15:24:49Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp

In response to this:

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 17, 2021

kubevirt-bot requested review from orenc1 and tiraboschi August 17, 2021 12:09

kubevirt-bot added the size/L label Aug 17, 2021

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 19, 2021

erkanerol force-pushed the remove-dependency branch from 7324e86 to 4f3b0b2 Compare August 23, 2021 10:32

kubevirt-bot added size/XL and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L labels Aug 23, 2021

nunnatsa reviewed Aug 25, 2021

View reviewed changes

pkg/webhooks/mutator/mutator.go Outdated Show resolved Hide resolved

pkg/webhooks/setup.go Outdated Show resolved Hide resolved

pkg/webhooks/setup.go Outdated Show resolved Hide resolved

erkanerol force-pushed the remove-dependency branch from 4f3b0b2 to bd351e7 Compare August 26, 2021 10:01

erkanerol force-pushed the remove-dependency branch from bd351e7 to 526252c Compare August 26, 2021 10:37

nunnatsa approved these changes Aug 26, 2021

View reviewed changes

kubevirt-bot assigned nunnatsa Aug 26, 2021

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2021

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2021

kubevirt-bot merged commit 997d753 into kubevirt:main Aug 26, 2021

erkanerol deleted the remove-dependency branch August 26, 2021 17:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove controller-runtime dependency from api package #1483

Remove controller-runtime dependency from api package #1483

erkanerol commented Aug 17, 2021

coveralls commented Aug 17, 2021 •

edited

Loading

hco-bot commented Aug 17, 2021

kubevirt-bot commented Aug 17, 2021

hco-bot commented Aug 17, 2021

kubevirt-bot commented Aug 17, 2021

hco-bot commented Aug 23, 2021

kubevirt-bot commented Aug 23, 2021

hco-bot commented Aug 23, 2021

kubevirt-bot commented Aug 23, 2021

hco-bot commented Aug 23, 2021

kubevirt-bot commented Aug 23, 2021

hco-bot commented Aug 23, 2021

kubevirt-bot commented Aug 23, 2021

nunnatsa left a comment

sonarcloud bot commented Aug 26, 2021

hco-bot commented Aug 26, 2021

kubevirt-bot commented Aug 26, 2021

hco-bot commented Aug 26, 2021

kubevirt-bot commented Aug 26, 2021

nunnatsa commented Aug 26, 2021

nunnatsa left a comment

kubevirt-bot commented Aug 26, 2021

nunnatsa commented Aug 26, 2021

kubevirt-bot commented Aug 26, 2021

openshift-ci bot commented Aug 26, 2021 •

edited

Loading

hco-bot commented Aug 26, 2021

kubevirt-bot commented Aug 26, 2021

hco-bot commented Aug 26, 2021

kubevirt-bot commented Aug 26, 2021

Remove controller-runtime dependency from api package #1483

Remove controller-runtime dependency from api package #1483

Conversation

erkanerol commented Aug 17, 2021

coveralls commented Aug 17, 2021 • edited Loading

Pull Request Test Coverage Report for Build 1170074672

💛 - Coveralls

hco-bot commented Aug 17, 2021

kubevirt-bot commented Aug 17, 2021

hco-bot commented Aug 17, 2021

kubevirt-bot commented Aug 17, 2021

hco-bot commented Aug 23, 2021

kubevirt-bot commented Aug 23, 2021

hco-bot commented Aug 23, 2021

kubevirt-bot commented Aug 23, 2021

hco-bot commented Aug 23, 2021

kubevirt-bot commented Aug 23, 2021

hco-bot commented Aug 23, 2021

kubevirt-bot commented Aug 23, 2021

nunnatsa left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Aug 26, 2021

hco-bot commented Aug 26, 2021

kubevirt-bot commented Aug 26, 2021

hco-bot commented Aug 26, 2021

kubevirt-bot commented Aug 26, 2021

nunnatsa commented Aug 26, 2021

nunnatsa left a comment

Choose a reason for hiding this comment

kubevirt-bot commented Aug 26, 2021

nunnatsa commented Aug 26, 2021

kubevirt-bot commented Aug 26, 2021

openshift-ci bot commented Aug 26, 2021 • edited Loading

hco-bot commented Aug 26, 2021

kubevirt-bot commented Aug 26, 2021

hco-bot commented Aug 26, 2021

kubevirt-bot commented Aug 26, 2021

coveralls commented Aug 17, 2021 •

edited

Loading

openshift-ci bot commented Aug 26, 2021 •

edited

Loading