Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable DownwardMetrics FeatureGate #1501

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Enable DownwardMetrics FeatureGate #1501

merged 1 commit into from
Aug 26, 2021

Conversation

tiraboschi
Copy link
Member

github.com/kubevirt/kubevirt/pull/5502
introduced a new Kubevirt feature named
downwardMetrics to expose host metrics
to guests.
The feature is controlled by a feature
gate named "DownwardMetrics".
Enable it in the list of HCO
opinionated feature gates.

Fixes: https://bugzilla.redhat.com/1991691

Signed-off-by: Simone Tiraboschi stirabos@redhat.com

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

  • PR Message
  • Commit Messages
  • How to test
  • Unit Tests
  • Functional Tests
  • User Documentation
  • Developer Documentation
  • Upgrade Scenario
  • Uninstallation Scenario
  • Backward Compatibility
  • Troubleshooting Friendly

Release note:

Enable DownwardMetrics FeatureGate on Kubevirt

@tiraboschi
Enable DownwardMetrics FeatureGate
f5cd1bd 
github.com/kubevirt/kubevirt/pull/5502
introduced a new Kubevirt feature named
downwardMetrics to expose host metrics
to guests.
The feature is controlled by a feature
gate named "DownwardMetrics".
Enable it in the list of HCO
opinionated feature gates.

Fixes: https://bugzilla.redhat.com/1991691

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S labels Aug 26, 2021
@sonarcloud
Copy link

sonarcloud bot commented Aug 26, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 1170300202

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.449%
Totals Coverage Status
Change from base Build 1167327466: 0.0%
Covered Lines: 3235
Relevant Lines: 4592
💛 - Coveralls

@erkanerol
Copy link
Contributor

@tiraboschi Could you please check this doc? https://github.com/kubevirt/hyperconverged-cluster-operator/blob/main/docs/cluster-configuration.md We may need to put/update something in that doc.

@nunnatsa
Copy link
Collaborator

@tiraboschi Could you please check this doc? https://github.com/kubevirt/hyperconverged-cluster-operator/blob/main/docs/cluster-configuration.md We may need to put/update something in that doc.

Since it's a part of the hard-coded FG list, the user can't modify it and so there is no point to document it under cluster configuration doc.

nunnatsa
nunnatsa approved these changes Aug 26, 2021
View reviewed changes
Copy link
Collaborator

@nunnatsa nunnatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2021
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2021
@hco-bot
Copy link
Collaborator

hco-bot commented Aug 26, 2021

hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp
okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-gcp

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp, ci/prow/okd-hco-e2e-image-index-gcp

In response to this:

hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp
okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Collaborator

hco-bot commented Aug 26, 2021

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp

In response to this:

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member Author

/retest

1 similar comment
@tiraboschi
Copy link
Member Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Aug 26, 2021 •
edited

@tiraboschi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/okd-hco-e2e-image-index-gcp f5cd1bd link /test okd-hco-e2e-image-index-gcp
ci/prow/hco-e2e-image-index-gcp f5cd1bd link /test hco-e2e-image-index-gcp
ci/prow/hco-e2e-kv-smoke-gcp f5cd1bd link /test hco-e2e-kv-smoke-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tiraboschi
Copy link
Member Author

/retest

@kubevirt-bot kubevirt-bot merged commit 2f46bbf into kubevirt:main Aug 26, 2021
@tiraboschi
Copy link
Member Author

/cherry-pick release-1.5

@tiraboschi
Copy link
Member Author

/cherrypick release-1.5

@kubevirt-bot
Copy link
Contributor

@tiraboschi: failed to push cherry-picked changes in GitHub: pushing failed, output: "To https://github.com/kubevirt-bot/hyperconverged-cluster-operator\n ! [remote rejected] cherry-pick-1501-to-release-1.5 -> cherry-pick-1501-to-release-1.5 (refusing to allow a Personal Access Token to create or update workflow .github/workflows/build-push-images.yaml without workflow scope)\nerror: failed to push some refs to 'https://github.com/kubevirt-bot/hyperconverged-cluster-operator'\n", error: exit status 1

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot
Copy link
Contributor

@tiraboschi: failed to push cherry-picked changes in GitHub: pushing failed, output: "To https://github.com/kubevirt-bot/hyperconverged-cluster-operator\n ! [remote rejected] cherry-pick-1501-to-release-1.5 -> cherry-pick-1501-to-release-1.5 (refusing to allow a Personal Access Token to create or update workflow .github/workflows/build-push-images.yaml without workflow scope)\nerror: failed to push some refs to 'https://github.com/kubevirt-bot/hyperconverged-cluster-operator'\n", error: exit status 1

In response to this:

/cherrypick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi tiraboschi deleted the fg_downwardmetrics branch August 26, 2021 22:06
@tiraboschi
Copy link
Member Author

/cherrypick release-1.5

@kubevirt-bot kubevirt-bot mentioned this pull request Aug 27, 2021
Merged
@kubevirt-bot
Copy link
Contributor

@tiraboschi: new pull request created: #1503

In response to this:

/cherrypick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunnatsa nunnatsa nunnatsa approved these changes

@erkanerol erkanerol Awaiting requested review from erkanerol

Assignees

@nunnatsa nunnatsa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tiraboschi @coveralls @erkanerol @nunnatsa @kubevirt-bot @hco-bot