-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable DownwardMetrics FeatureGate #1501
Conversation
github.com/kubevirt/kubevirt/pull/5502 introduced a new Kubevirt feature named downwardMetrics to expose host metrics to guests. The feature is controlled by a feature gate named "DownwardMetrics". Enable it in the list of HCO opinionated feature gates. Fixes: https://bugzilla.redhat.com/1991691 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
Kudos, SonarCloud Quality Gate passed!
|
Pull Request Test Coverage Report for Build 1170300202
💛 - Coveralls |
@tiraboschi Could you please check this doc? https://github.com/kubevirt/hyperconverged-cluster-operator/blob/main/docs/cluster-configuration.md We may need to put/update something in that doc. |
Since it's a part of the hard-coded FG list, the user can't modify it and so there is no point to document it under cluster configuration doc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nunnatsa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp, ci/prow/okd-hco-e2e-image-index-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
hco-e2e-kv-smoke-azure lane succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
1 similar comment
/retest |
@tiraboschi: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
/cherry-pick release-1.5 |
/cherrypick release-1.5 |
@tiraboschi: failed to push cherry-picked changes in GitHub: pushing failed, output: "To https://github.com/kubevirt-bot/hyperconverged-cluster-operator\n ! [remote rejected] cherry-pick-1501-to-release-1.5 -> cherry-pick-1501-to-release-1.5 (refusing to allow a Personal Access Token to create or update workflow In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@tiraboschi: failed to push cherry-picked changes in GitHub: pushing failed, output: "To https://github.com/kubevirt-bot/hyperconverged-cluster-operator\n ! [remote rejected] cherry-pick-1501-to-release-1.5 -> cherry-pick-1501-to-release-1.5 (refusing to allow a Personal Access Token to create or update workflow In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-1.5 |
@tiraboschi: new pull request created: #1503 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
github.com/kubevirt/kubevirt/pull/5502
introduced a new Kubevirt feature named
downwardMetrics to expose host metrics
to guests.
The feature is controlled by a feature
gate named "DownwardMetrics".
Enable it in the list of HCO
opinionated feature gates.
Fixes: https://bugzilla.redhat.com/1991691
Signed-off-by: Simone Tiraboschi stirabos@redhat.com
Reviewer Checklist
Release note: