Add new recording rule "cluster:vmi_request_cpu_cores:sum" #1530

erkanerol · 2021-09-15T11:15:29Z

We want to add a new metric into cluster-monitoring-operator to track sum of cpu requests of virt-launcher pods.

"cluster" prefix means that the scope of the metric is cluster-wide like the other metrics in the cluster-monitoring-operator. "cnv" is not used here since it is not related to this upstream project

Details:

It relies on cpu requests on pod specs.
This recording rule only accounts virt-launcher pods and ignores pods of control-plane.
It only accounts "Running" pods. Other states (Pending, Succeeded, Failed) are ignored.
It ignores initContainers

PR in telemetry side: openshift/cluster-monitoring-operator#1384

Signed-off-by: Erkan Erol eerol@redhat.com

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

Release note:

Add  new recording rule ("cnv:vmi_request_cpu_cores:sum" ) to keep track of sum of allocated CPUs to VMIs.

coveralls · 2021-09-15T11:19:15Z

Pull Request Test Coverage Report for Build 1262062426

5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 68.208%

Totals
Change from base Build 1258966348:	0.03%
Covered Lines:	3392
Relevant Lines:	4973

💛 - Coveralls

hco-bot · 2021-09-15T12:36:17Z

okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-gcp
hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

kubevirt-bot · 2021-09-15T12:36:24Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp, ci/prow/okd-hco-e2e-image-index-gcp

In response to this:

okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-gcp
hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-09-15T13:04:02Z

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure

kubevirt-bot · 2021-09-15T13:04:05Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-09-15T14:14:33Z

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

kubevirt-bot · 2021-09-15T14:14:37Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp

In response to this:

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-09-15T14:29:24Z

hco-e2e-upgrade-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-aws

kubevirt-bot · 2021-09-15T14:29:26Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-aws

In response to this:

hco-e2e-upgrade-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

erkanerol · 2021-09-16T05:31:22Z

/test okd-hco-e2e-upgrade-index-aws

kubevirt-bot · 2021-09-16T05:31:23Z

@erkanerol: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.21

Use /test all to run all jobs.

In response to this:

/test okd-hco-e2e-upgrade-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-09-16T06:53:55Z

okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp

kubevirt-bot · 2021-09-16T06:53:57Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-upgrade-index-gcp

In response to this:

okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

erkanerol · 2021-09-16T07:46:20Z

@sradco Could you please review this PR?

erkanerol · 2021-09-20T10:58:49Z

/hold I did some tests for LiveMigration feature. Current metric accounts the value of Completed pods as well. We need to check pod/container statuses.

erkanerol · 2021-09-20T12:39:22Z

/unhold

hco-bot · 2021-09-20T13:30:32Z

okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp
hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-aws

kubevirt-bot · 2021-09-20T13:30:37Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-aws, ci/prow/hco-e2e-image-index-gcp, ci/prow/okd-hco-e2e-upgrade-index-gcp

In response to this:

okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp
hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-09-20T14:50:01Z

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

kubevirt-bot · 2021-09-20T14:50:22Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp

In response to this:

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hack/prom-rule-ci/prom-rules-tests.yaml

We want to add a new metric into cluster-monitoring-operator to track sum of cpu requests of virt-launcher pods. Signed-off-by: Erkan Erol <eerol@redhat.com>

sonarcloud · 2021-09-22T13:51:48Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

hco-bot · 2021-09-22T15:28:09Z

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure
hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-aws
hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure

kubevirt-bot · 2021-09-22T15:28:15Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-aws, ci/prow/hco-e2e-image-index-gcp, ci/prow/hco-e2e-upgrade-index-azure, ci/prow/hco-e2e-upgrade-prev-index-azure

In response to this:

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure
hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-aws
hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-09-22T16:43:54Z

@erkanerol: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hco-e2e-image-index-aws	`1d1fd43`	link	true	`/test hco-e2e-image-index-aws`
ci/prow/okd-hco-e2e-upgrade-index-gcp	`1d1fd43`	link	true	`/test okd-hco-e2e-upgrade-index-gcp`
ci/prow/hco-e2e-upgrade-index-azure	`1d1fd43`	link	true	`/test hco-e2e-upgrade-index-azure`
ci/prow/okd-hco-e2e-image-index-gcp	`1d1fd43`	link	true	`/test okd-hco-e2e-image-index-gcp`
ci/prow/hco-e2e-image-index-gcp	`1d1fd43`	link	true	`/test hco-e2e-image-index-gcp`
ci/prow/hco-e2e-upgrade-prev-index-azure	`1d1fd43`	link	true	`/test hco-e2e-upgrade-prev-index-azure`
ci/prow/hco-e2e-kv-smoke-gcp	`1d1fd43`	link	true	`/test hco-e2e-kv-smoke-gcp`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

hco-bot · 2021-09-22T17:00:03Z

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

kubevirt-bot · 2021-09-22T17:00:11Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp

In response to this:

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

erkanerol · 2021-09-23T07:39:31Z

/test okd-hco-e2e-image-index-aws
/test okd-hco-e2e-upgrade-index-aws

kubevirt-bot · 2021-09-23T07:39:32Z

@erkanerol: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.21

Use /test all to run all jobs.

In response to this:

/test okd-hco-e2e-image-index-aws
/test okd-hco-e2e-upgrade-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-09-23T08:59:26Z

okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-gcp

kubevirt-bot · 2021-09-23T08:59:29Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-image-index-gcp

In response to this:

okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2021-09-23T09:54:40Z

/approve

kubevirt-bot · 2021-09-23T09:54:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [tiraboschi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tiraboschi · 2021-09-23T09:54:48Z

/override-bot

erkanerol · 2021-09-23T10:14:04Z

/override ci/prow/okd-hco-e2e-upgrade-index-gcp

kubevirt-bot · 2021-09-23T10:14:06Z

@erkanerol: Overrode contexts on behalf of erkanerol: ci/prow/okd-hco-e2e-upgrade-index-gcp

In response to this:

/override ci/prow/okd-hco-e2e-upgrade-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 15, 2021

kubevirt-bot requested review from orenc1 and sradco September 15, 2021 11:15

kubevirt-bot added size/M release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 15, 2021

erkanerol mentioned this pull request Sep 16, 2021

Add cluster:vmi_request_cpu_cores:sum into Telemetry openshift/cluster-monitoring-operator#1384

Merged

2 tasks

kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2021

erkanerol force-pushed the new-cpu-metric branch 2 times, most recently from c8fde84 to 5a220f4 Compare September 20, 2021 11:48

kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2021

tiraboschi reviewed Sep 22, 2021

View reviewed changes

hack/prom-rule-ci/prom-rules-tests.yaml Outdated Show resolved Hide resolved

Add new recording rule "cnv:vmi_request_cpu_cores:sum"

1d1fd43

We want to add a new metric into cluster-monitoring-operator to track sum of cpu requests of virt-launcher pods. Signed-off-by: Erkan Erol <eerol@redhat.com>

erkanerol force-pushed the new-cpu-metric branch from 5a220f4 to 1d1fd43 Compare September 22, 2021 13:50

erkanerol changed the title ~~Add new recording rule "cnv:vmi_request_cpu_cores:sum"~~ Add new recording rule "cluster:vmi_request_cpu_cores:sum" Sep 23, 2021

tiraboschi approved these changes Sep 23, 2021

View reviewed changes

kubevirt-bot assigned tiraboschi Sep 23, 2021

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2021

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2021

kubevirt-bot merged commit e1d81c4 into kubevirt:main Sep 23, 2021

Add new recording rule "cluster:vmi_request_cpu_cores:sum" #1530

Add new recording rule "cluster:vmi_request_cpu_cores:sum" #1530

Conversation

erkanerol commented Sep 15, 2021 • edited Loading

coveralls commented Sep 15, 2021 • edited Loading

Pull Request Test Coverage Report for Build 1262062426

💛 - Coveralls

hco-bot commented Sep 15, 2021

kubevirt-bot commented Sep 15, 2021

hco-bot commented Sep 15, 2021

kubevirt-bot commented Sep 15, 2021

hco-bot commented Sep 15, 2021

kubevirt-bot commented Sep 15, 2021

hco-bot commented Sep 15, 2021

kubevirt-bot commented Sep 15, 2021

erkanerol commented Sep 16, 2021

kubevirt-bot commented Sep 16, 2021

hco-bot commented Sep 16, 2021

kubevirt-bot commented Sep 16, 2021

erkanerol commented Sep 16, 2021

erkanerol commented Sep 20, 2021

erkanerol commented Sep 20, 2021

hco-bot commented Sep 20, 2021

kubevirt-bot commented Sep 20, 2021

hco-bot commented Sep 20, 2021

kubevirt-bot commented Sep 20, 2021

sonarcloud bot commented Sep 22, 2021

hco-bot commented Sep 22, 2021

kubevirt-bot commented Sep 22, 2021

openshift-ci bot commented Sep 22, 2021 • edited Loading

hco-bot commented Sep 22, 2021

kubevirt-bot commented Sep 22, 2021

erkanerol commented Sep 23, 2021

kubevirt-bot commented Sep 23, 2021

hco-bot commented Sep 23, 2021

kubevirt-bot commented Sep 23, 2021

tiraboschi commented Sep 23, 2021

kubevirt-bot commented Sep 23, 2021

tiraboschi commented Sep 23, 2021

erkanerol commented Sep 23, 2021

kubevirt-bot commented Sep 23, 2021

erkanerol commented Sep 15, 2021 •

edited

Loading

coveralls commented Sep 15, 2021 •

edited

Loading

openshift-ci bot commented Sep 22, 2021 •

edited

Loading