Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid setting Evict workloadUpdates strategy #1542

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Avoid setting Evict workloadUpdates strategy #1542

merged 1 commit into from
Sep 29, 2021

Conversation

tiraboschi
Copy link
Member

@tiraboschi tiraboschi commented Sep 28, 2021 •
edited

Evict workloadUpdates strategy can be disruptive
for existing workloads,
avoid setting it by default and let the user
eventually opt-in.

Signed-off-by: Simone Tiraboschi stirabos@redhat.com

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2008900

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

  • PR Message
  • Commit Messages
  • How to test
  • Unit Tests
  • Functional Tests
  • User Documentation
  • Developer Documentation
  • Upgrade Scenario
  • Uninstallation Scenario
  • Backward Compatibility
  • Troubleshooting Friendly

Release note:

Avoid setting Evict workloadUpdates strategy

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S labels Sep 28, 2021
@tiraboschi
Copy link
Member Author

/hold
until we get a final decision on this

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 28, 2021
@tiraboschi
Avoid setting Evict workloadUpdates strategy
2d96baf 
Evict workloadUpdates strategy can be disruptive
for existing workloads,
avoid setting it by default and let the user
eventually opt-in.

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 1282134397

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.208%
Totals Coverage Status
Change from base Build 1276126380: 0.0%
Covered Lines: 3392
Relevant Lines: 4973
💛 - Coveralls

@openshift-ci
Copy link

openshift-ci bot commented Sep 28, 2021

@tiraboschi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hco-e2e-image-index-gcp 2d96baf link true /test hco-e2e-image-index-gcp
ci/prow/okd-hco-e2e-upgrade-index-aws 2d96baf link true /test okd-hco-e2e-upgrade-index-aws
ci/prow/okd-hco-e2e-image-index-gcp 2d96baf link true /test okd-hco-e2e-image-index-gcp
ci/prow/hco-e2e-image-index-azure 2d96baf link true /test hco-e2e-image-index-azure
ci/prow/hco-e2e-kv-smoke-gcp 2d96baf link true /test hco-e2e-kv-smoke-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tiraboschi
Copy link
Member Author

/override-bot

@tiraboschi tiraboschi mentioned this pull request Sep 28, 2021
Merged
11 tasks
@tiraboschi
Copy link
Member Author

hco-e2e-image-index-aws passed
/override ci/prow/hco-e2e-image-index-azure
/override ci/prow/hco-e2e-image-index-gcp

@kubevirt-bot
Copy link
Contributor

@tiraboschi: Overrode contexts on behalf of tiraboschi: ci/prow/hco-e2e-image-index-azure, ci/prow/hco-e2e-image-index-gcp

In response to this:

hco-e2e-image-index-aws passed
/override ci/prow/hco-e2e-image-index-azure
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member Author

hco-e2e-kv-smoke-azure passed
/override ci/prow/hco-e2e-kv-smoke-gcp

@kubevirt-bot
Copy link
Contributor

@tiraboschi: Overrode contexts on behalf of tiraboschi: ci/prow/hco-e2e-kv-smoke-gcp

In response to this:

hco-e2e-kv-smoke-azure passed
/override ci/prow/hco-e2e-kv-smoke-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member Author

okd-hco-e2e-image-index-aws passed
/override okd-hco-e2e-image-index-gcp

@kubevirt-bot
Copy link
Contributor

@tiraboschi: /override requires a failed status context or a job name to operate on.
The following unknown contexts were given:

  • okd-hco-e2e-image-index-gcp

Only the following contexts were expected:

  • ci/prow/ci-index
  • ci/prow/ci-index-hco-upgrade-bundle
  • ci/prow/ci-index-hco-upgrade-prev-bundle
  • ci/prow/hco-e2e-image-index-aws
  • ci/prow/hco-e2e-image-index-azure
  • ci/prow/hco-e2e-image-index-gcp
  • ci/prow/hco-e2e-kv-smoke-azure
  • ci/prow/hco-e2e-kv-smoke-gcp
  • ci/prow/hco-e2e-upgrade-index-aws
  • ci/prow/hco-e2e-upgrade-index-azure
  • ci/prow/hco-e2e-upgrade-prev-index-aws
  • ci/prow/hco-e2e-upgrade-prev-index-azure
  • ci/prow/images
  • ci/prow/okd-ci-index
  • ci/prow/okd-ci-index-hco-upgrade-bundle
  • ci/prow/okd-ci-index-hco-upgrade-prev-bundle
  • ci/prow/okd-hco-e2e-image-index-aws
  • ci/prow/okd-hco-e2e-image-index-gcp
  • ci/prow/okd-hco-e2e-upgrade-index-aws
  • ci/prow/okd-hco-e2e-upgrade-index-gcp
  • ci/prow/okd-images
  • coverage/coveralls
  • dco
  • pull-hyperconverged-cluster-operator-e2e-k8s-1.21
  • tide

In response to this:

okd-hco-e2e-image-index-aws passed
/override okd-hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member Author

okd-hco-e2e-upgrade-index-gcp passed
/override ci/prow/okd-hco-e2e-upgrade-index-aws

@kubevirt-bot
Copy link
Contributor

@tiraboschi: Overrode contexts on behalf of tiraboschi: ci/prow/okd-hco-e2e-upgrade-index-aws

In response to this:

okd-hco-e2e-upgrade-index-gcp passed
/override ci/prow/okd-hco-e2e-upgrade-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member Author

okd-hco-e2e-image-index-aws passed
/override ci/prow/okd-hco-e2e-image-index-gcp

@kubevirt-bot
Copy link
Contributor

@tiraboschi: Overrode contexts on behalf of tiraboschi: ci/prow/okd-hco-e2e-image-index-gcp

In response to this:

okd-hco-e2e-image-index-aws passed
/override ci/prow/okd-hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi added a commit to tiraboschi/hyperconverged-cluster-operator that referenced this pull request Sep 29, 2021
@tiraboschi
[release-1.5] Avoid setting Evict workloadUpdates strategy
7179ab7 
Evict workloadUpdates strategy can be disruptive
for existing workloads,
avoid setting it by default and let the user
eventually opt-in.

This is a manual cherry-pick of kubevirt#1542

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
@tiraboschi
Copy link
Member Author

https://bugzilla.redhat.com/show_bug.cgi?id=2008900 got marked as blocker+
/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 29, 2021
nunnatsa
nunnatsa approved these changes Sep 29, 2021
View reviewed changes
Copy link
Collaborator

@nunnatsa nunnatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2021
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2021
@kubevirt-bot kubevirt-bot merged commit 457e1ef into kubevirt:main Sep 29, 2021
@tiraboschi tiraboschi deleted the no_vm_evict branch September 29, 2021 15:16
kubevirt-bot pushed a commit that referenced this pull request Sep 29, 2021
@tiraboschi
[release-1.5] Avoid setting Evict workloadUpdates strategy (#1543)
362e051 
Evict workloadUpdates strategy can be disruptive
for existing workloads,
avoid setting it by default and let the user
eventually opt-in.

This is a manual cherry-pick of #1542

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunnatsa nunnatsa nunnatsa approved these changes

@erkanerol erkanerol Awaiting requested review from erkanerol

Assignees

@nunnatsa nunnatsa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tiraboschi @coveralls @kubevirt-bot @nunnatsa