-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix an issue with setting the dataImportCronTemplates field #1553
Fix an issue with setting the dataImportCronTemplates field #1553
Conversation
Since the CRD did not contain the field of the dataImportCronTemplate.metadata objects, the API server pruned the name field, and when HCO called to SSP webhook to update SSP with new dataImportCronTemplate, the SSP webhook rejected the request because of the missing name field. This PR fixes this issue by forcing the metadata filed, by adding the CRD generator crdgen.Parser's `GenerateEmbeddedObjectMeta` to `true`. Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Pull Request Test Coverage Report for Build 1304569360
💛 - Coveralls |
hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test okd-hco-e2e-image-index-aws |
@nunnatsa: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
hco-e2e-kv-smoke-azure lane succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@nunnatsa: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
okd-hco-e2e-image-index-gcp lane succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-image-index-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tiraboschi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Since the CRD did not contain the field of the dataImportCronTemplate.metadata objects, the API server pruned the name field, and when HCO called to SSP webhook to update SSP with new dataImportCronTemplate, the SSP webhook rejected the request because of the missing name field.
This PR fixes this issue by forcing the metadata filed, by adding the CRD generator crdgen.Parser's
GenerateEmbeddedObjectMeta
totrue
.Signed-off-by: Nahshon Unna-Tsameret nunnatsa@redhat.com
Reviewer Checklist
Release note: