Update found object for PriorityClass #1565

erkanerol · 2021-10-11T13:52:33Z

We don't update PriorityClass object. We delete and
re-create. The "found" object is used for updating
object references in status of HCO. Therefore, it
must be up-to-date.

Signed-off-by: Erkan Erol eerol@redhat.com

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

Release note:

Fix an issue in updating PriorityClass object in relatedObjects.

coveralls · 2021-10-11T14:04:21Z

Pull Request Test Coverage Report for Build 1336651953

3 of 6 (50.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 68.43%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/controller/operands/kubevirt.go	3	6	50.0%

Totals
Change from base Build 1333198294:	0.1%
Covered Lines:	3440
Relevant Lines:	5027

💛 - Coveralls

hco-bot · 2021-10-11T15:16:33Z

okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp
okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-gcp
hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

kubevirt-bot · 2021-10-11T15:16:37Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp, ci/prow/okd-hco-e2e-image-index-gcp, ci/prow/okd-hco-e2e-upgrade-index-gcp

In response to this:

okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp
okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-gcp
hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-10-11T15:35:57Z

hco-e2e-upgrade-prev-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-aws

kubevirt-bot · 2021-10-11T15:36:00Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-aws

In response to this:

hco-e2e-upgrade-prev-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-10-11T17:02:13Z

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

kubevirt-bot · 2021-10-11T17:02:17Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp

In response to this:

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/controller/operands/kubevirt.go

nunnatsa

/approve

nunnatsa

Please add unit test

nunnatsa · 2021-10-12T10:32:19Z

/cancel approve

hco-bot · 2021-10-12T11:38:11Z

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

kubevirt-bot · 2021-10-12T11:38:13Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-10-12T11:48:27Z

okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp
hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure

nunnatsa

/approve

kubevirt-bot · 2021-10-13T09:16:41Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [nunnatsa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

hco-bot · 2021-10-13T09:56:09Z

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

kubevirt-bot · 2021-10-13T09:56:12Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-10-13T10:18:17Z

okd-hco-e2e-upgrade-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-aws

kubevirt-bot · 2021-10-13T10:18:20Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-upgrade-index-aws

In response to this:

okd-hco-e2e-upgrade-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-10-13T10:46:44Z

hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure

kubevirt-bot · 2021-10-13T10:46:49Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-azure

In response to this:

hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-10-13T10:57:08Z

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure

kubevirt-bot · 2021-10-13T10:57:11Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-10-13T11:15:34Z

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

kubevirt-bot · 2021-10-13T11:15:36Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-azure

In response to this:

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

erkanerol · 2021-10-13T11:43:39Z

/retest-required

tiraboschi · 2021-10-13T12:39:35Z

/retest

hco-bot · 2021-10-13T14:39:31Z

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

kubevirt-bot · 2021-10-13T14:39:37Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp

In response to this:

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

erkanerol · 2021-10-14T07:06:23Z

@nunnatsa May I get an approval?

nunnatsa · 2021-10-14T07:30:43Z

/test hco-e2e-upgrade-prev-index-azure-sno

kubevirt-bot · 2021-10-14T07:30:45Z

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.21

Use /test all to run all jobs.

In response to this:

/test hco-e2e-upgrade-prev-index-azure-sno

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa · 2021-10-14T10:53:42Z

/test hco-e2e-upgrade-prev-index-azure-sno

kubevirt-bot · 2021-10-14T10:53:45Z

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.21

Use /test all to run all jobs.

In response to this:

/test hco-e2e-upgrade-prev-index-azure-sno

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2021-10-14T12:39:02Z

/test hco-e2e-upgrade-prev-index-azure-sno

kubevirt-bot · 2021-10-14T12:39:04Z

@tiraboschi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.21

Use /test all to run all jobs.

In response to this:

/test hco-e2e-upgrade-prev-index-azure-sno

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2021-10-14T17:41:34Z

/retest

openshift-ci · 2021-10-14T19:18:14Z

@erkanerol: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-hco-e2e-upgrade-index-aws	`a21eb51`	link	true	`/test okd-hco-e2e-upgrade-index-aws`
ci/prow/hco-e2e-image-index-gcp	`a21eb51`	link	true	`/test hco-e2e-image-index-gcp`
ci/prow/hco-e2e-upgrade-index-azure	`a21eb51`	link	true	`/test hco-e2e-upgrade-index-azure`
ci/prow/hco-e2e-image-index-azure	`a21eb51`	link	true	`/test hco-e2e-image-index-azure`
ci/prow/hco-e2e-upgrade-prev-index-azure	`a21eb51`	link	true	`/test hco-e2e-upgrade-prev-index-azure`
ci/prow/hco-e2e-kv-smoke-gcp	`a21eb51`	link	true	`/test hco-e2e-kv-smoke-gcp`
ci/prow/hco-e2e-upgrade-prev-index-azure-sno	`a21eb51`	link	false	`/test hco-e2e-upgrade-prev-index-azure-sno`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

tiraboschi · 2021-10-15T10:18:49Z

hco-e2e-upgrade-prev-index-azure-sno seems still not so reliable but the issue is not related to this specific PR
/override ci/prow/hco-e2e-upgrade-prev-index-azure-sno

kubevirt-bot · 2021-10-15T10:18:57Z

@tiraboschi: Overrode contexts on behalf of tiraboschi: ci/prow/hco-e2e-upgrade-prev-index-azure-sno

In response to this:

hco-e2e-upgrade-prev-index-azure-sno seems still not so reliable but the issue is not related to this specific PR
/override ci/prow/hco-e2e-upgrade-prev-index-azure-sno

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 11, 2021

kubevirt-bot requested review from orenc1 and tiraboschi October 11, 2021 13:52

erkanerol changed the title ~~Update found object for PriorityClass~~ WIP: Update found object for PriorityClass Oct 11, 2021

kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS labels Oct 11, 2021

nunnatsa reviewed Oct 12, 2021

View reviewed changes

pkg/controller/operands/kubevirt.go Outdated Show resolved Hide resolved

erkanerol force-pushed the fix-priority-class branch from 170af3b to 4201901 Compare October 12, 2021 10:20

kubevirt-bot added size/S and removed size/XS labels Oct 12, 2021

erkanerol force-pushed the fix-priority-class branch from 4201901 to 4f3aba0 Compare October 12, 2021 10:22

nunnatsa approved these changes Oct 12, 2021

View reviewed changes

kubevirt-bot assigned nunnatsa Oct 12, 2021

kubevirt-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 12, 2021

nunnatsa requested changes Oct 12, 2021

View reviewed changes

kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2021

nunnatsa removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2021

nunnatsa approved these changes Oct 13, 2021

View reviewed changes

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2021

kubevirt-bot merged commit 930dde5 into kubevirt:main Oct 15, 2021

erkanerol deleted the fix-priority-class branch October 17, 2021 15:47

Update found object for PriorityClass #1565

Update found object for PriorityClass #1565

Conversation

erkanerol commented Oct 11, 2021 • edited Loading

coveralls commented Oct 11, 2021 • edited Loading

Pull Request Test Coverage Report for Build 1336651953

💛 - Coveralls

hco-bot commented Oct 11, 2021

kubevirt-bot commented Oct 11, 2021

hco-bot commented Oct 11, 2021

kubevirt-bot commented Oct 11, 2021

hco-bot commented Oct 11, 2021

kubevirt-bot commented Oct 11, 2021

nunnatsa left a comment

Choose a reason for hiding this comment

nunnatsa left a comment

Choose a reason for hiding this comment

nunnatsa commented Oct 12, 2021

hco-bot commented Oct 12, 2021

kubevirt-bot commented Oct 12, 2021

hco-bot commented Oct 12, 2021

nunnatsa left a comment

Choose a reason for hiding this comment

kubevirt-bot commented Oct 13, 2021

hco-bot commented Oct 13, 2021

kubevirt-bot commented Oct 13, 2021

hco-bot commented Oct 13, 2021

kubevirt-bot commented Oct 13, 2021

hco-bot commented Oct 13, 2021

kubevirt-bot commented Oct 13, 2021

hco-bot commented Oct 13, 2021

kubevirt-bot commented Oct 13, 2021

hco-bot commented Oct 13, 2021

kubevirt-bot commented Oct 13, 2021

erkanerol commented Oct 13, 2021

tiraboschi commented Oct 13, 2021

hco-bot commented Oct 13, 2021

kubevirt-bot commented Oct 13, 2021

erkanerol commented Oct 14, 2021

nunnatsa commented Oct 14, 2021

kubevirt-bot commented Oct 14, 2021

nunnatsa commented Oct 14, 2021

kubevirt-bot commented Oct 14, 2021

tiraboschi commented Oct 14, 2021

kubevirt-bot commented Oct 14, 2021

tiraboschi commented Oct 14, 2021

openshift-ci bot commented Oct 14, 2021

tiraboschi commented Oct 15, 2021

kubevirt-bot commented Oct 15, 2021

erkanerol commented Oct 11, 2021 •

edited

Loading

coveralls commented Oct 11, 2021 •

edited

Loading