Avoid setting a default for bandwidthPerMigration and dropping it if == 64Mi #1567
Conversation
kubevirt-bot
added
release-note
In the past we were setting a default of 64Mi for spec.livemigrationconfig.bandwidthpermigration but the value was simply ignored by kubevirt due to an ancient bug. Now the bug on kubevirt/kubevirt got fixed and unfortunately we discover that the default that kubevirt and then HCO set in the past doesn't fit production use cases. Let's avoid setting a default for spec.livemigrationconfig.bandwidthpermigration and let's explicitly delete it on upgrades if set to "64Mi" which is not acceptable. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2011179 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi
force-pushed
the
fix_bandwidthpermigration
branch
from
818571b
to
4c7ef3b
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Pull Request Test Coverage Report for Build 1329738166
💛 - Coveralls |
|
hco-e2e-image-index-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-upgrade-index-azure lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-aws, ci/prow/okd-hco-e2e-upgrade-index-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override-bot |
|
hco-e2e-kv-smoke-azure lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
In the past we were setting a default of 64Mi for spec.livemigrationconfig.bandwidthpermigration but the value was simply ignored by kubevirt due to an ancient bug. Now the bug on kubevirt/kubevirt got fixed and unfortunately we discover that the default that kubevirt and then HCO set in the past doesn't fit production use cases. Let's avoid setting a default for spec.livemigrationconfig.bandwidthpermigration and let's explicitly delete it on upgrades if set to "64Mi" which is not acceptable. This is a manual cherry-pick of kubevirt#1567 Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2011179 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nunnatsa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
@tiraboschi: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
okd-hco-e2e-image-index-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-image-index-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In the past we were setting a default of 64Mi for spec.livemigrationconfig.bandwidthpermigration but the value was simply ignored by kubevirt due to an ancient bug. Now the bug on kubevirt/kubevirt got fixed and unfortunately we discover that the default that kubevirt and then HCO set in the past doesn't fit production use cases. Let's avoid setting a default for spec.livemigrationconfig.bandwidthpermigration and let's explicitly delete it on upgrades if set to "64Mi" which is not acceptable. This is a manual cherry-pick of #1567 Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2011179 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
In the past we were setting a default of 64Mi for
spec.livemigrationconfig.bandwidthpermigration but
the value was simply ignored by kubevirt due to
an ancient bug.
Now the bug on kubevirt/kubevirt got fixed and
unfortunately we discover that the default that
kubevirt and then HCO set in the past doesn't
fit production use cases.
Let's avoid setting a default for
spec.livemigrationconfig.bandwidthpermigration
and let's explicitly delete it on upgrades
if set to "64Mi" which is not acceptable.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2011179
Signed-off-by: Simone Tiraboschi stirabos@redhat.com
Reviewer Checklist
Release note: