Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable default workloadUpdates strategies #1577

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Disable default workloadUpdates strategies #1577

merged 1 commit into from
Oct 27, 2021

Conversation

tiraboschi
Copy link
Member

Enabling workloadUpdates strategies by default
can expose unexpected behaviours.
Temporary disable it until we properly
covered all the corner cases.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2017394

Signed-off-by: Simone Tiraboschi stirabos@redhat.com

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

  • PR Message
  • Commit Messages
  • How to test
  • Unit Tests
  • Functional Tests
  • User Documentation
  • Developer Documentation
  • Upgrade Scenario
  • Uninstallation Scenario
  • Backward Compatibility
  • Troubleshooting Friendly

Release note:

Disable default workloadUpdates strategies

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 26, 2021
@tiraboschi tiraboschi force-pushed the disable_workload_update_strategies branch 2 times, most recently from eb4b79a to 84489fb Compare October 26, 2021 16:27
@tiraboschi tiraboschi mentioned this pull request Oct 26, 2021
Merged
11 tasks
@tiraboschi tiraboschi force-pushed the disable_workload_update_strategies branch 2 times, most recently from 64b3d72 to d5a7b0d Compare October 26, 2021 16:53
@coveralls
Copy link
Collaborator

coveralls commented Oct 26, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1387491228

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.268%
Totals Coverage Status
Change from base Build 1362921611: 0.0%
Covered Lines: 3545
Relevant Lines: 5045
💛 - Coveralls

@tiraboschi
Copy link
Member Author

/retest

2 similar comments
@tiraboschi
Copy link
Member Author

/retest

@tiraboschi
Copy link
Member Author

/retest

@orenc1
Copy link
Collaborator

orenc1 commented Oct 26, 2021

unrelated build failures
/retest
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2021
@tiraboschi
Copy link
Member Author

/retest

@tiraboschi
Copy link
Member Author

/hold
double thinking at this, it's probably better to simply avoid providing any default for now

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 26, 2021
@tiraboschi tiraboschi force-pushed the disable_workload_update_strategies branch from d5a7b0d to ae7ebfa Compare October 26, 2021 20:22
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2021
@tiraboschi tiraboschi force-pushed the disable_workload_update_strategies branch from ae7ebfa to c1bcd0e Compare October 26, 2021 20:28
@tiraboschi
Copy link
Member Author

/unhold

tiraboschi added a commit to tiraboschi/hyperconverged-cluster-operator that referenced this pull request Oct 26, 2021
@tiraboschi
[release-1.5] Disable default workloadUpdates strategies
3b21c2a 
Enabling workloadUpdates strategies by default
can expose unexpected behaviours.
Temporary disable it until we properly
covered all the corner cases.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2017394

This is a manual cherry pick of kubevirt#1577

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
@tiraboschi
Disable default workloadUpdates strategies
fcd629f 
Enabling workloadUpdates strategies by default
can expose unexpected behaviours.
Temporary disable it until we properly
covered all the corner cases.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2017394

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
@tiraboschi tiraboschi force-pushed the disable_workload_update_strategies branch from c1bcd0e to fcd629f Compare October 26, 2021 21:05
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hco-bot
Copy link
Collaborator

hco-bot commented Oct 26, 2021

hco-e2e-upgrade-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-aws
hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp, ci/prow/hco-e2e-upgrade-index-aws

In response to this:

hco-e2e-upgrade-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-aws
hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Collaborator

hco-bot commented Oct 26, 2021

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-azure

In response to this:

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Oct 26, 2021

@tiraboschi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hco-e2e-upgrade-index-aws fcd629f link true /test hco-e2e-upgrade-index-aws
ci/prow/hco-e2e-image-index-gcp fcd629f link true /test hco-e2e-image-index-gcp
ci/prow/hco-e2e-upgrade-prev-index-azure fcd629f link true /test hco-e2e-upgrade-prev-index-azure
ci/prow/hco-e2e-kv-smoke-gcp fcd629f link true /test hco-e2e-kv-smoke-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hco-bot
Copy link
Collaborator

hco-bot commented Oct 27, 2021

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp

In response to this:

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa
nunnatsa approved these changes Oct 27, 2021
View reviewed changes
Copy link
Collaborator

@nunnatsa nunnatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2021
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2021
@kubevirt-bot kubevirt-bot merged commit f0c5bbf into kubevirt:main Oct 27, 2021
@tiraboschi tiraboschi deleted the disable_workload_update_strategies branch October 27, 2021 06:00
kubevirt-bot pushed a commit that referenced this pull request Oct 27, 2021
@tiraboschi
[release-1.5] Disable default workloadUpdates strategies (#1578)
ea58ca8 
Enabling workloadUpdates strategies by default
can expose unexpected behaviours.
Temporary disable it until we properly
covered all the corner cases.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2017394

This is a manual cherry pick of #1577

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
@tiraboschi tiraboschi mentioned this pull request Oct 27, 2021
Merged
11 tasks
tiraboschi added a commit to tiraboschi/hyperconverged-cluster-operator that referenced this pull request Nov 16, 2021
@tiraboschi
Enable default workloadUpdates strategies
4250048 
Prepare a PR to enable again default workloadUpdates
strategies for the next release.

The feature got temporary disabled with kubevirt#1577
being still not so mature.

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
kubevirt-bot pushed a commit that referenced this pull request Nov 17, 2021
@tiraboschi
Enable default workloadUpdates strategies (#1579)
8c24891 
Prepare a PR to enable again default workloadUpdates
strategies for the next release.

The feature got temporary disabled with #1577
being still not so mature.

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunnatsa nunnatsa nunnatsa approved these changes

@erkanerol erkanerol Awaiting requested review from erkanerol

@sradco sradco Awaiting requested review from sradco

@orenc1 orenc1 Awaiting requested review from orenc1

Assignees

@orenc1 orenc1

@nunnatsa nunnatsa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tiraboschi @coveralls @orenc1 @hco-bot @kubevirt-bot @nunnatsa