Apply upgrade patches according to a json file #1586
Conversation
kubevirt-bot
added
dco-signoff: yes
tiraboschi
force-pushed
the
patch_defaults
branch
from
c9f6463
to
cdec455
Compare
Pull Request Test Coverage Report for Build 1443881131
💛 - Coveralls |
|
hco-e2e-image-index-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-image-index-sno-azure lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-image-index-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-kv-smoke-azure lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tiraboschi
force-pushed
the
patch_defaults
branch
from
cdec455
to
d9bdaf4
Compare
|
hco-e2e-image-index-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-image-index-azure, hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-kv-smoke-azure lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tiraboschi
force-pushed
the
patch_defaults
branch
2 times, most recently
from
12fd7cf
to
c0e5b0d
Compare
|
hco-e2e-kv-smoke-azure lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Apply upgrade patches according to a yaml files
shipped within the container.
The operator will read the yaml file expecting
a fixed struct.
Now it handles only jsonpatches to be applied
on the HCO CR, in the future the same mechanism
could be easily extended to delete leftovers
or patch other objects.
Now it expects something like:
```json
{
"hcoCRPatchList": [
{
"semverRange": ">=1.4.0 <=1.5.0",
"jsonPatch": [
{
"op": "replace",
"path": "/spec/featureGates/sriovLiveMigration",
"value": true
}
]
}
]
}
```
where hcoCRPatchList is a list of upgrade patches.
Each hcoCRPatch consists in a semver range
( https://github.com/blang/semver#ranges ) of affected
source versions and a json patch
( https://datatracker.ietf.org/doc/html/rfc6902 )
to be applied during the upgrade if relevant.
Applying it to set
/spec/featureGates/sriovLiveMigration = true
when upgrading from 1.4.z and 1.5.0 to the current version.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2018468
Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi
force-pushed
the
patch_defaults
branch
from
a80445d
to
5369359
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nunnatsa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/retest |
|
hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp, ci/prow/hco-e2e-image-index-sno-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
okd-hco-e2e-upgrade-index-gcp lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-upgrade-index-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-upgrade-prev-index-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@tiraboschi: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
hco-e2e-kv-smoke-azure lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…t#1586) Apply upgrade patches according to a yaml files shipped within the container. The operator will read the yaml file expecting a fixed struct. Now it handles only jsonpatches to be applied on the HCO CR, in the future the same mechanism could be easily extended to delete leftovers or patch other objects. Now it expects something like: ```json { "hcoCRPatchList": [ { "semverRange": ">=1.4.0 <=1.5.0", "jsonPatch": [ { "op": "replace", "path": "/spec/featureGates/sriovLiveMigration", "value": true } ] } ] } ``` where hcoCRPatchList is a list of upgrade patches. Each hcoCRPatch consists in a semver range ( https://github.com/blang/semver#ranges ) of affected source versions and a json patch ( https://datatracker.ietf.org/doc/html/rfc6902 ) to be applied during the upgrade if relevant. Applying it to set /spec/featureGates/sriovLiveMigration = true when upgrading from 1.4.z and 1.5.0 to the current version. This is a manual cherry-pick of kubevirt#1586 Bump github.com/evanphx/json-patch => v5.6.0+incompatible to be aligned with the main branch. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2018468 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
…1599) Apply upgrade patches according to a yaml files shipped within the container. The operator will read the yaml file expecting a fixed struct. Now it handles only jsonpatches to be applied on the HCO CR, in the future the same mechanism could be easily extended to delete leftovers or patch other objects. Now it expects something like: ```json { "hcoCRPatchList": [ { "semverRange": ">=1.4.0 <=1.5.0", "jsonPatch": [ { "op": "replace", "path": "/spec/featureGates/sriovLiveMigration", "value": true } ] } ] } ``` where hcoCRPatchList is a list of upgrade patches. Each hcoCRPatch consists in a semver range ( https://github.com/blang/semver#ranges ) of affected source versions and a json patch ( https://datatracker.ietf.org/doc/html/rfc6902 ) to be applied during the upgrade if relevant. Applying it to set /spec/featureGates/sriovLiveMigration = true when upgrading from 1.4.z and 1.5.0 to the current version. This is a manual cherry-pick of #1586 Bump github.com/evanphx/json-patch => v5.6.0+incompatible to be aligned with the main branch. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2018468 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi
changed the title
Apply upgrade patches according to a json files
shipped within the container.
The operator will read the json file expecting
a fixed struct.
Now it handles only jsonpatches to be applied
on the HCO CR, in the future the same mechanism
could be easily extended to delete leftovers
or patch other objects.
Now it expects something like:
{ "hcoCRPatchList": [ { "semverRange": ">=1.4.0 <=1.5.0", "jsonPatch": [ { "op": "replace", "path": "/spec/featureGates/sriovLiveMigration", "value": true } ] } ] }where hcoCRPatchList is a list of upgrade patches.
Each hcoCRPatch consists in a semver range
( https://github.com/blang/semver#ranges ) of affected
source versions and a json patch
( https://datatracker.ietf.org/doc/html/rfc6902 )
to be applied during the upgrade if relevant.
Applying it to set
/spec/featureGates/sriovLiveMigration = truewhen upgrading from 1.4.z and 1.5.0 to the current version.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2018468
Signed-off-by: Simone Tiraboschi stirabos@redhat.com
Reviewer Checklist
Release note: