Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump HPPO to v0.11.0 #1603

Merged
merged 2 commits into from
Dec 3, 2021
Merged

Bump HPPO to v0.11.0 #1603

merged 2 commits into from
Dec 3, 2021

Conversation

tiraboschi
Copy link
Member

@tiraboschi tiraboschi commented Nov 11, 2021 •
edited by erkanerol

Bump HPPO to v0.11.0, which introduces webhooks.

Signed-off-by: Alexander Wels awels@redhat.com

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

  • PR Message
  • Commit Messages
  • How to test
  • Unit Tests
  • Functional Tests
  • User Documentation
  • Developer Documentation
  • Upgrade Scenario
  • Uninstallation Scenario
  • Backward Compatibility
  • Troubleshooting Friendly

Release note:

Bump HPPO to v0.11.0

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 11, 2021
@tiraboschi tiraboschi mentioned this pull request Nov 11, 2021
Closed
11 tasks
@tiraboschi
Copy link
Member Author

/hold
do not merge: using latest floating tag for hhpo

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2021
@coveralls
Copy link
Collaborator

coveralls commented Nov 11, 2021 •
edited

Pull Request Test Coverage Report for Build 1531885329

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.035%
Totals Coverage Status
Change from base Build 1530897861: 0.0%
Covered Lines: 3576
Relevant Lines: 5106
💛 - Coveralls

@tiraboschi
Copy link
Member Author

/retest

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 13, 2021
@kubevirt-bot kubevirt-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 14, 2021
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 22, 2021
@tiraboschi
Copy link
Member Author

/override-bot

@tiraboschi
Copy link
Member Author

/retest

@tiraboschi
Copy link
Member Author

/override-bot

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 24, 2021
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 26, 2021
@erkanerol erkanerol force-pushed the add_hpp_operator_webhook_st branch 2 times, most recently from 4494732 to 31f1aa9 Compare December 2, 2021 12:41
@erkanerol erkanerol changed the title Add admissionwebhook configuration to hpp-operator Bump HPPO to v0.11.0 Dec 2, 2021
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 2, 2021
@erkanerol erkanerol force-pushed the add_hpp_operator_webhook_st branch 2 times, most recently from e8d2aaa to 6b9df1e Compare December 2, 2021 13:11
@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2021
awels and others added 2 commits December 2, 2021 21:08
@awels
Add admissionwebhook configuration to hpp-operator
b0a9af2 
Temproary using hppo latest image to test
the integration.
TODO: replace it with the next tagged release
once ready.

Signed-off-by: Alexander Wels <awels@redhat.com>
Bump HPP Operator to v0.11.0
9877d5e 
Signed-off-by: Erkan Erol <eerol@redhat.com>
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2021
@sonarcloud
Copy link

sonarcloud bot commented Dec 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tiraboschi
Copy link
Member Author

/override-bot

@openshift-ci
Copy link

openshift-ci bot commented Dec 2, 2021

@tiraboschi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hco-e2e-image-index-gcp 9877d5e link true /test hco-e2e-image-index-gcp
ci/prow/okd-hco-e2e-upgrade-index-gcp 9877d5e link true /test okd-hco-e2e-upgrade-index-gcp
ci/prow/hco-e2e-upgrade-prev-index-azure 9877d5e link true /test hco-e2e-upgrade-prev-index-azure
ci/prow/hco-e2e-image-index-sno-aws 9877d5e link false /test hco-e2e-image-index-sno-aws
ci/prow/hco-e2e-upgrade-prev-index-sno-aws 9877d5e link false /test hco-e2e-upgrade-prev-index-sno-aws
ci/prow/hco-e2e-kv-smoke-gcp 9877d5e link true /test hco-e2e-kv-smoke-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tiraboschi
Copy link
Member Author

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2021
@hco-bot
Copy link
Collaborator

hco-bot commented Dec 2, 2021

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp
hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws
hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws
hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure
hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp
okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp, ci/prow/hco-e2e-image-index-sno-aws, ci/prow/hco-e2e-kv-smoke-gcp, ci/prow/hco-e2e-upgrade-prev-index-azure, ci/prow/hco-e2e-upgrade-prev-index-sno-aws, ci/prow/okd-hco-e2e-upgrade-index-gcp

In response to this:

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp
hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws
hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws
hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure
hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp
okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member Author

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2021
@erkanerol
Copy link
Contributor

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2021
@kubevirt-bot kubevirt-bot merged commit 6c956f7 into kubevirt:main Dec 3, 2021
@tiraboschi tiraboschi deleted the add_hpp_operator_webhook_st branch December 3, 2021 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awels awels Awaiting requested review from awels

@nunnatsa nunnatsa Awaiting requested review from nunnatsa

@orenc1 orenc1 Awaiting requested review from orenc1

Assignees

@erkanerol erkanerol

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tiraboschi @coveralls @hco-bot @kubevirt-bot @erkanerol @awels