Add common labels into alert definitions #1622

assafad · 2021-11-23T10:01:05Z

We want to be able to list all kubevirt alerts so we added labels to differentiate them.

Signed-off-by: assaf-admi aadmi@redhat.com

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

Release note:

Added common labels into alert definitions

openshift-ci · 2021-11-23T10:01:15Z

Hi @assaf-admi. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot · 2021-11-23T10:01:16Z

Hi @assaf-admi. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

erkanerol · 2021-11-23T10:05:17Z

/ok-to-test

coveralls · 2021-11-23T10:09:26Z

Pull Request Test Coverage Report for Build 1495196498

6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 69.607%

Totals
Change from base Build 1495142533:	0.02%
Covered Lines:	3472
Relevant Lines:	4988

💛 - Coveralls

hco-bot · 2021-11-23T11:33:35Z

hco-e2e-upgrade-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-aws
hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

kubevirt-bot · 2021-11-23T11:33:38Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp, ci/prow/hco-e2e-upgrade-index-aws

In response to this:

hco-e2e-upgrade-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-aws
hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-11-23T11:43:21Z

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

kubevirt-bot · 2021-11-23T11:43:24Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-azure

In response to this:

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-11-23T11:53:24Z

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure

kubevirt-bot · 2021-11-23T11:53:26Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: assaf-admi <aadmi@redhat.com>

sonarcloud · 2021-11-23T14:28:40Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

hco-bot · 2021-11-23T16:16:22Z

hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-aws
hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

kubevirt-bot · 2021-11-23T16:16:26Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-aws, ci/prow/hco-e2e-image-index-gcp, ci/prow/hco-e2e-image-index-sno-aws

In response to this:

hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-aws
hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-11-23T17:34:57Z

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

kubevirt-bot · 2021-11-23T17:34:59Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp

In response to this:

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

erkanerol · 2021-11-25T09:33:41Z

@sradco could you please review this PR?

nunnatsa · 2021-11-27T10:26:30Z

/retest

openshift-ci · 2021-11-27T10:52:40Z

@assaf-admi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hco-e2e-image-index-aws	`9b894e0`	link	true	`/test hco-e2e-image-index-aws`
ci/prow/hco-e2e-image-index-gcp	`9b894e0`	link	true	`/test hco-e2e-image-index-gcp`
ci/prow/hco-e2e-image-index-sno-aws	`9b894e0`	link	false	`/test hco-e2e-image-index-sno-aws`
ci/prow/hco-e2e-kv-smoke-gcp	`9b894e0`	link	true	`/test hco-e2e-kv-smoke-gcp`
ci/prow/hco-e2e-upgrade-index-azure	`9b894e0`	link	true	`/test hco-e2e-upgrade-index-azure`
ci/prow/hco-e2e-upgrade-index-sno-aws	`9b894e0`	link	false	`/test hco-e2e-upgrade-index-sno-aws`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

hco-bot · 2021-11-27T11:53:09Z

hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure

kubevirt-bot · 2021-11-27T11:53:12Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-azure

In response to this:

hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-11-27T12:13:10Z

hco-e2e-upgrade-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-aws

kubevirt-bot · 2021-11-27T12:13:13Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-sno-aws

In response to this:

hco-e2e-upgrade-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa · 2021-11-27T13:40:10Z

/lgtm
/approve

kubevirt-bot · 2021-11-27T13:40:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [nunnatsa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 23, 2021

kubevirt-bot requested review from nunnatsa and orenc1 November 23, 2021 10:01

openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 23, 2021

kubevirt-bot added the size/M label Nov 23, 2021

openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 23, 2021

Add common labels into alert definitions

9b894e0

Signed-off-by: assaf-admi <aadmi@redhat.com>

kubevirt-bot assigned nunnatsa Nov 27, 2021

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2021

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2021

kubevirt-bot merged commit c08a413 into kubevirt:main Nov 27, 2021

assafad deleted the labels branch December 12, 2021 11:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add common labels into alert definitions #1622

Add common labels into alert definitions #1622

assafad commented Nov 23, 2021 •

edited

Loading

openshift-ci bot commented Nov 23, 2021

kubevirt-bot commented Nov 23, 2021

erkanerol commented Nov 23, 2021

coveralls commented Nov 23, 2021 •

edited

Loading

hco-bot commented Nov 23, 2021

kubevirt-bot commented Nov 23, 2021

hco-bot commented Nov 23, 2021

kubevirt-bot commented Nov 23, 2021

hco-bot commented Nov 23, 2021

kubevirt-bot commented Nov 23, 2021

sonarcloud bot commented Nov 23, 2021

hco-bot commented Nov 23, 2021

kubevirt-bot commented Nov 23, 2021

hco-bot commented Nov 23, 2021

kubevirt-bot commented Nov 23, 2021

erkanerol commented Nov 25, 2021

nunnatsa commented Nov 27, 2021

openshift-ci bot commented Nov 27, 2021 •

edited

Loading

hco-bot commented Nov 27, 2021

kubevirt-bot commented Nov 27, 2021

hco-bot commented Nov 27, 2021

kubevirt-bot commented Nov 27, 2021

nunnatsa commented Nov 27, 2021

kubevirt-bot commented Nov 27, 2021

Add common labels into alert definitions #1622

Add common labels into alert definitions #1622

Conversation

assafad commented Nov 23, 2021 • edited Loading

openshift-ci bot commented Nov 23, 2021

kubevirt-bot commented Nov 23, 2021

erkanerol commented Nov 23, 2021

coveralls commented Nov 23, 2021 • edited Loading

Pull Request Test Coverage Report for Build 1495196498

💛 - Coveralls

hco-bot commented Nov 23, 2021

kubevirt-bot commented Nov 23, 2021

hco-bot commented Nov 23, 2021

kubevirt-bot commented Nov 23, 2021

hco-bot commented Nov 23, 2021

kubevirt-bot commented Nov 23, 2021

sonarcloud bot commented Nov 23, 2021

hco-bot commented Nov 23, 2021

kubevirt-bot commented Nov 23, 2021

hco-bot commented Nov 23, 2021

kubevirt-bot commented Nov 23, 2021

erkanerol commented Nov 25, 2021

nunnatsa commented Nov 27, 2021

openshift-ci bot commented Nov 27, 2021 • edited Loading

hco-bot commented Nov 27, 2021

kubevirt-bot commented Nov 27, 2021

hco-bot commented Nov 27, 2021

kubevirt-bot commented Nov 27, 2021

nunnatsa commented Nov 27, 2021

kubevirt-bot commented Nov 27, 2021

assafad commented Nov 23, 2021 •

edited

Loading

coveralls commented Nov 23, 2021 •

edited

Loading

openshift-ci bot commented Nov 27, 2021 •

edited

Loading