Configure Kubevirt for SNO mode #1639

tiraboschi · 2021-12-02T17:55:01Z

Configure Kubevirt for SNO mode

Read openshiftconfigv1.Infrastructure and tune
kubevirt accordingly:

InfrastructureTopology=SingleReplica => .spec.infra.replicas=1
InfrastructureTopology=SingleReplica => LiveMigrationGate=false

ControlPlaneTopology is currently ignored because
it doesn't impact on Kubevirt since no kubevirt pods
runs on master nodes.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2026336

Signed-off-by: Simone Tiraboschi stirabos@redhat.com

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

Release note:

Configure Kubevirt for SNO mode

coveralls · 2021-12-02T17:59:31Z

Pull Request Test Coverage Report for Build 1559566266

55 of 65 (84.62%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 69.936%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/util/cluster.go	36	46	78.26%

Totals
Change from base Build 1558957628:	0.1%
Covered Lines:	3580
Relevant Lines:	5119

💛 - Coveralls

hco-bot · 2021-12-02T22:27:33Z

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

kubevirt-bot · 2021-12-02T22:27:36Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-12-02T22:39:27Z

hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

kubevirt-bot · 2021-12-02T22:39:29Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-aws

In response to this:

hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-12-02T22:47:10Z

hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure
hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws

kubevirt-bot · 2021-12-02T22:47:13Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-sno-azure, ci/prow/hco-e2e-upgrade-prev-index-sno-aws

In response to this:

hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure
hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-12-03T10:10:01Z

okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp
hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure

kubevirt-bot · 2021-12-03T10:10:06Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp, ci/prow/hco-e2e-upgrade-index-azure, ci/prow/okd-hco-e2e-upgrade-index-gcp

In response to this:

okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp
hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-12-03T10:31:13Z

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure
hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

kubevirt-bot · 2021-12-03T10:31:16Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-aws, ci/prow/hco-e2e-upgrade-prev-index-azure

In response to this:

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure
hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-12-03T11:43:12Z

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

kubevirt-bot · 2021-12-03T11:43:14Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp

In response to this:

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot · 2021-12-03T18:15:12Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-12-03T18:36:51Z

hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws

kubevirt-bot · 2021-12-03T18:36:53Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-sno-aws

In response to this:

hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-12-03T18:50:34Z

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

kubevirt-bot · 2021-12-03T18:50:37Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-azure

In response to this:

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-12-03T19:43:22Z

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

kubevirt-bot · 2021-12-03T19:43:25Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp

In response to this:

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa · 2021-12-05T13:14:12Z

pkg/controller/operands/kubevirt.go

-func hcoConfig2KvConfig(hcoConfig hcov1beta1.HyperConvergedConfig) *kubevirtcorev1.ComponentConfig {
-	if hcoConfig.NodePlacement != nil {
+func hcoConfig2KvConfig(hcoConfig hcov1beta1.HyperConvergedConfig, infrastructureHighlyAvailable bool) *kubevirtcorev1.ComponentConfig {
+	if hcoConfig.NodePlacement != nil || !infrastructureHighlyAvailable {


not sure it's so important, but I think it's the two cases in this condition handled desperately below with almost no common code (beside the new kvConfig var and the return statement). Maybe we ca save one layer of nesting and make the sonarCloud happier.

nunnatsa · 2021-12-05T13:15:37Z

pkg/util/cluster.go

@@ -18,13 +21,17 @@ type ClusterInfo interface {
 	IsRunningLocally() bool
 	GetDomain() string
 	IsManagedByOLM() bool
+	IsControlPlaneHighlyAvailable() bool


This is not in use in the code. Maybe we want to remove it to simplify the interface?

we are not using it now with kubevirt, but I'm pretty sure we will start using it in the future with other components like CNAO which is scheduling also on masters.

Read openshiftconfigv1.Infrastructure and tune kubevirt accordingly: - InfrastructureTopology=SingleReplica => .spec.infra.replicas=1 - InfrastructureTopology=SingleReplica => LiveMigrationGate=false ControlPlaneTopology is currently ignored because it doesn't impact on Kubevirt since no kubevirt pods runs on master nodes. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2026336 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

sonarcloud · 2021-12-09T16:04:25Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

No Coverage information
0.0% Duplication

hco-bot · 2021-12-09T17:25:32Z

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

kubevirt-bot · 2021-12-09T17:25:45Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-12-09T17:46:15Z

hco-e2e-upgrade-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-aws
hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

kubevirt-bot · 2021-12-09T17:46:19Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-aws, ci/prow/hco-e2e-upgrade-index-sno-aws

In response to this:

hco-e2e-upgrade-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-aws
hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-12-09T17:53:20Z

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

kubevirt-bot · 2021-12-09T17:53:23Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-azure

In response to this:

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-12-09T18:59:42Z

@tiraboschi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hco-e2e-image-index-gcp	`d13f42e`	link	true	`/test hco-e2e-image-index-gcp`
ci/prow/hco-e2e-upgrade-index-sno-aws	`d13f42e`	link	false	`/test hco-e2e-upgrade-index-sno-aws`
ci/prow/hco-e2e-image-index-sno-aws	`d13f42e`	link	false	`/test hco-e2e-image-index-sno-aws`
ci/prow/hco-e2e-upgrade-prev-index-azure	`d13f42e`	link	true	`/test hco-e2e-upgrade-prev-index-azure`
ci/prow/hco-e2e-kv-smoke-gcp	`d13f42e`	link	true	`/test hco-e2e-kv-smoke-gcp`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

hco-bot · 2021-12-09T19:07:56Z

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

kubevirt-bot · 2021-12-09T19:07:59Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp

In response to this:

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa · 2021-12-09T21:16:36Z

/lgtm
/approve

kubevirt-bot · 2021-12-09T21:16:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [nunnatsa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tiraboschi requested review from erkanerol and nunnatsa December 2, 2021 17:55

kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 2, 2021

kubevirt-bot requested a review from sradco December 2, 2021 17:55

kubevirt-bot added the size/L label Dec 2, 2021

tiraboschi force-pushed the sno_opt branch from 1478dac to 5b70c44 Compare December 2, 2021 17:55

tiraboschi force-pushed the sno_opt branch from 5b70c44 to 0201e78 Compare December 2, 2021 21:05

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 3, 2021

tiraboschi force-pushed the sno_opt branch from 0201e78 to 1c2a927 Compare December 3, 2021 08:40

kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 3, 2021

tiraboschi changed the title ~~Configure Kubevirt for SNO mode~~ WIP: Configure Kubevirt for SNO mode Dec 3, 2021

kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 3, 2021

tiraboschi force-pushed the sno_opt branch from 1c2a927 to 5f75b21 Compare December 3, 2021 15:30

kubevirt-bot added size/XL and removed size/L labels Dec 3, 2021

tiraboschi changed the title ~~WIP: Configure Kubevirt for SNO mode~~ Configure Kubevirt for SNO mode Dec 3, 2021

nunnatsa reviewed Dec 5, 2021

View reviewed changes

tiraboschi force-pushed the sno_opt branch from 07d9095 to ef3b122 Compare December 9, 2021 14:59

tiraboschi requested a review from nunnatsa December 9, 2021 15:00

tiraboschi force-pushed the sno_opt branch from ef3b122 to d13f42e Compare December 9, 2021 16:03

kubevirt-bot assigned nunnatsa Dec 9, 2021

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2021

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2021

kubevirt-bot merged commit 49f419b into kubevirt:main Dec 9, 2021

tiraboschi deleted the sno_opt branch December 10, 2021 07:41

Configure Kubevirt for SNO mode #1639

Configure Kubevirt for SNO mode #1639

Conversation

tiraboschi commented Dec 2, 2021 • edited Loading

coveralls commented Dec 2, 2021 • edited Loading

Pull Request Test Coverage Report for Build 1559566266

💛 - Coveralls

hco-bot commented Dec 2, 2021

kubevirt-bot commented Dec 2, 2021

hco-bot commented Dec 2, 2021

kubevirt-bot commented Dec 2, 2021

hco-bot commented Dec 2, 2021

kubevirt-bot commented Dec 2, 2021

hco-bot commented Dec 3, 2021

kubevirt-bot commented Dec 3, 2021

hco-bot commented Dec 3, 2021

kubevirt-bot commented Dec 3, 2021

hco-bot commented Dec 3, 2021

kubevirt-bot commented Dec 3, 2021

kubevirt-bot commented Dec 3, 2021

hco-bot commented Dec 3, 2021

kubevirt-bot commented Dec 3, 2021

hco-bot commented Dec 3, 2021

kubevirt-bot commented Dec 3, 2021

hco-bot commented Dec 3, 2021

kubevirt-bot commented Dec 3, 2021

nunnatsa Dec 5, 2021

Choose a reason for hiding this comment

tiraboschi Dec 9, 2021

Choose a reason for hiding this comment

nunnatsa Dec 5, 2021

Choose a reason for hiding this comment

tiraboschi Dec 9, 2021

Choose a reason for hiding this comment

sonarcloud bot commented Dec 9, 2021

hco-bot commented Dec 9, 2021

kubevirt-bot commented Dec 9, 2021

hco-bot commented Dec 9, 2021

kubevirt-bot commented Dec 9, 2021

hco-bot commented Dec 9, 2021

kubevirt-bot commented Dec 9, 2021

openshift-ci bot commented Dec 9, 2021

hco-bot commented Dec 9, 2021

kubevirt-bot commented Dec 9, 2021

nunnatsa commented Dec 9, 2021

kubevirt-bot commented Dec 9, 2021

tiraboschi commented Dec 2, 2021 •

edited

Loading

coveralls commented Dec 2, 2021 •

edited

Loading