Bug 2030660: Fix bug where imageStream are not get reconciled #1654

nunnatsa · 2021-12-12T10:16:03Z

Fix by start watching imageStreams. Add an E2E test to validate.

Signed-off-by: Nahshon Unna-Tsameret nunnatsa@redhat.com

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

Release note:

Fix bugzilla bug #2030660

coveralls · 2021-12-12T10:26:43Z

Pull Request Test Coverage Report for Build 1571980594

1 of 2 (50.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 69.986%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/controller/hyperconverged/hyperconverged_controller.go	0	1	0.0%

Totals
Change from base Build 1566848339:	0.04%
Covered Lines:	3584
Relevant Lines:	5121

💛 - Coveralls

hco-bot · 2021-12-12T13:07:55Z

hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws

kubevirt-bot · 2021-12-12T13:07:58Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-sno-aws

In response to this:

hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa · 2021-12-12T15:02:50Z

/test hco-e2e-upgrade-prev-index-aws

kubevirt-bot · 2021-12-12T15:02:52Z

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build-hco-test-utils-image
/test pull-hyperconverged-cluster-operator-e2e-k8s-1.21

Use /test all to run the following jobs that were automatically triggered:

pull-hyperconverged-cluster-operator-e2e-k8s-1.21

In response to this:

/test hco-e2e-upgrade-prev-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-12-12T17:37:00Z

hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws

kubevirt-bot · 2021-12-12T17:37:03Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-sno-aws

In response to this:

hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-12-12T18:49:11Z

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

kubevirt-bot · 2021-12-12T18:49:13Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp

In response to this:

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa · 2021-12-13T05:57:44Z

/retest

erkanerol · 2021-12-13T06:24:29Z

hack/check_golden_images.sh

+  ./hack/retry.sh 10 3 "${KUBECTL_BINARY} patch imageStream -n ${IMAGES_NS} centos8 --type=json -p '[{\"op\": \"add\", \"path\": \"/metadata/labels/test-label\", \"value\": \"test\"}]'"
+  sleep 10
+  # HCO expect to remove the test-label label from the image stream
+  ./hack/retry.sh 10 3 "[[ -z $(${KUBECTL_BINARY} get imageStream -n ${IMAGES_NS} centos8 -o jsonpath='{.metadata.labels.test-label}') ]]" "${KUBECTL_BINARY} get imageStream -n ${IMAGES_NS} centos8 -o yaml"


@nunnatsa Is this line correct?

yes. What do you mean?

I understand that retry.sh is using the last part as debug parameter. there is no issue 👍

hco-bot · 2021-12-13T06:38:51Z

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

kubevirt-bot · 2021-12-13T06:38:53Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-azure

In response to this:

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa · 2021-12-13T07:25:23Z

/retest

nunnatsa · 2021-12-13T07:55:37Z

/test hco-e2e-upgrade-prev-index-sno-aws

kubevirt-bot · 2021-12-13T07:55:39Z

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build-hco-test-utils-image
/test pull-hyperconverged-cluster-operator-e2e-k8s-1.21

Use /test all to run the following jobs that were automatically triggered:

pull-hyperconverged-cluster-operator-e2e-k8s-1.21

In response to this:

/test hco-e2e-upgrade-prev-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

sonarcloud · 2021-12-13T08:35:31Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

hco-bot · 2021-12-13T09:53:32Z

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

kubevirt-bot · 2021-12-13T09:53:35Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

erkanerol · 2021-12-13T09:56:24Z

/lgtm

nunnatsa · 2021-12-13T10:53:16Z

/test hco-e2e-upgrade-index-sno-aws
/test hco-e2e-upgrade-index-sno-azure

kubevirt-bot · 2021-12-13T10:53:18Z

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build-hco-test-utils-image
/test pull-hyperconverged-cluster-operator-e2e-k8s-1.21

Use /test all to run the following jobs that were automatically triggered:

pull-hyperconverged-cluster-operator-e2e-k8s-1.21

In response to this:

/test hco-e2e-upgrade-index-sno-aws
/test hco-e2e-upgrade-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-12-13T11:43:14Z

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

kubevirt-bot · 2021-12-13T11:43:17Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp

In response to this:

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa · 2021-12-13T11:55:35Z

/test hco-e2e-upgrade-index-sno-aws

kubevirt-bot · 2021-12-13T11:55:36Z

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build-hco-test-utils-image
/test pull-hyperconverged-cluster-operator-e2e-k8s-1.21

Use /test all to run the following jobs that were automatically triggered:

pull-hyperconverged-cluster-operator-e2e-k8s-1.21

In response to this:

/test hco-e2e-upgrade-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-12-13T12:22:18Z

@nunnatsa: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hco-e2e-image-index-gcp	`5a31324`	link	true	`/test hco-e2e-image-index-gcp`
ci/prow/hco-e2e-kv-smoke-gcp	`5a31324`	link	true	`/test hco-e2e-kv-smoke-gcp`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

nunnatsa · 2021-12-13T12:24:10Z

/test hco-e2e-upgrade-index-sno-azure

kubevirt-bot · 2021-12-13T12:24:11Z

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build-hco-test-utils-image
/test pull-hyperconverged-cluster-operator-e2e-k8s-1.21

Use /test all to run the following jobs that were automatically triggered:

pull-hyperconverged-cluster-operator-e2e-k8s-1.21

In response to this:

/test hco-e2e-upgrade-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa · 2021-12-13T13:11:22Z

/test hco-e2e-upgrade-index-sno-aws

kubevirt-bot · 2021-12-13T13:11:24Z

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build-hco-test-utils-image
/test pull-hyperconverged-cluster-operator-e2e-k8s-1.21

Use /test all to run the following jobs that were automatically triggered:

pull-hyperconverged-cluster-operator-e2e-k8s-1.21

In response to this:

/test hco-e2e-upgrade-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

erkanerol · 2021-12-13T14:13:02Z

/approve

kubevirt-bot · 2021-12-13T14:13:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erkanerol

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [erkanerol]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

nunnatsa requested review from erkanerol and tiraboschi December 12, 2021 10:16

kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 12, 2021

kubevirt-bot requested a review from sradco December 12, 2021 10:16

kubevirt-bot added the size/M label Dec 12, 2021

nunnatsa force-pushed the fix-2030660 branch from 91f8402 to 834d39b Compare December 12, 2021 10:22

nunnatsa force-pushed the fix-2030660 branch from 834d39b to 852a5be Compare December 12, 2021 11:32

nunnatsa force-pushed the fix-2030660 branch 2 times, most recently from 56d02fc to dcb0161 Compare December 12, 2021 14:29

nunnatsa force-pushed the fix-2030660 branch from dcb0161 to b88300d Compare December 12, 2021 15:49

nunnatsa force-pushed the fix-2030660 branch from b88300d to a19f162 Compare December 13, 2021 04:38

kubevirt-bot added size/L and removed size/M labels Dec 13, 2021

erkanerol reviewed Dec 13, 2021

View reviewed changes

nunnatsa force-pushed the fix-2030660 branch from a19f162 to 9d7de58 Compare December 13, 2021 06:56

Fix bug where imageStream are not get reconciled

5a31324

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

nunnatsa force-pushed the fix-2030660 branch from 9d7de58 to 5a31324 Compare December 13, 2021 08:33

kubevirt-bot assigned erkanerol Dec 13, 2021

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2021

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2021

kubevirt-bot merged commit 1345946 into kubevirt:main Dec 13, 2021

nunnatsa deleted the fix-2030660 branch December 13, 2021 14:51

Bug 2030660: Fix bug where imageStream are not get reconciled #1654

Bug 2030660: Fix bug where imageStream are not get reconciled #1654

Conversation

nunnatsa commented Dec 12, 2021

coveralls commented Dec 12, 2021 • edited Loading

Pull Request Test Coverage Report for Build 1571980594

💛 - Coveralls

hco-bot commented Dec 12, 2021

kubevirt-bot commented Dec 12, 2021

nunnatsa commented Dec 12, 2021

kubevirt-bot commented Dec 12, 2021

hco-bot commented Dec 12, 2021

kubevirt-bot commented Dec 12, 2021

hco-bot commented Dec 12, 2021

kubevirt-bot commented Dec 12, 2021

nunnatsa commented Dec 13, 2021

erkanerol Dec 13, 2021

Choose a reason for hiding this comment

nunnatsa Dec 13, 2021

Choose a reason for hiding this comment

erkanerol Dec 13, 2021

Choose a reason for hiding this comment

hco-bot commented Dec 13, 2021

kubevirt-bot commented Dec 13, 2021

nunnatsa commented Dec 13, 2021

nunnatsa commented Dec 13, 2021

kubevirt-bot commented Dec 13, 2021

sonarcloud bot commented Dec 13, 2021

hco-bot commented Dec 13, 2021

kubevirt-bot commented Dec 13, 2021

erkanerol commented Dec 13, 2021

nunnatsa commented Dec 13, 2021

kubevirt-bot commented Dec 13, 2021

hco-bot commented Dec 13, 2021

kubevirt-bot commented Dec 13, 2021

nunnatsa commented Dec 13, 2021

kubevirt-bot commented Dec 13, 2021

openshift-ci bot commented Dec 13, 2021 • edited Loading

nunnatsa commented Dec 13, 2021

kubevirt-bot commented Dec 13, 2021

nunnatsa commented Dec 13, 2021

kubevirt-bot commented Dec 13, 2021

erkanerol commented Dec 13, 2021

kubevirt-bot commented Dec 13, 2021

coveralls commented Dec 12, 2021 •

edited

Loading

openshift-ci bot commented Dec 13, 2021 •

edited

Loading