Reconcile ImageStream only if the FG is true #1659
Conversation
kubevirt-bot
added
release-note
Pull Request Test Coverage Report for Build 1586043444
💛 - Coveralls |
|
/retest |
1 similar comment
|
/retest |
|
hco-e2e-upgrade-prev-index-sno-azure lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-sno-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-kv-smoke-azure lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
If the enableCommonBootImageImport FG is set, create the imageStreams and reconcile them If the enableCommonBootImageImport FG is not set, remove the imageStreams Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
nunnatsa
force-pushed
the
reconcile-imagestream-fg
branch
from
fff05d9
to
c76d18b
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
/lgtm |
|
okd-hco-e2e-upgrade-index-gcp, okd-hco-e2e-upgrade-index-gcp lanes succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp, ci/prow/hco-e2e-image-index-sno-aws, ci/prow/hco-e2e-upgrade-index-sno-aws, ci/prow/okd-hco-e2e-upgrade-index-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override-bot |
|
hco-e2e-image-index-sno-azure lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-aws, ci/prow/hco-e2e-upgrade-index-sno-aws, ci/prow/okd-hco-e2e-upgrade-index-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override-bot |
|
hco-e2e-upgrade-prev-index-sno-azure lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-sno-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-image-index-aws lane succeeded. |
|
@nunnatsa: Overrode contexts on behalf of nunnatsa: ci/prow/hco-e2e-image-index-azure, ci/prow/hco-e2e-image-index-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-upgrade-index-azure lane succeeded. |
|
@nunnatsa: Overrode contexts on behalf of nunnatsa: ci/prow/hco-e2e-upgrade-index-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@nunnatsa: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
hco-e2e-kv-smoke-azure, hco-e2e-kv-smoke-azure lanes succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: erkanerol The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
| @@ -5,6 +5,12 @@ set -ex | |||
| IMAGES_NS=${IMAGES_NS:-kubevirt-os-images} | |||
|
|
|||
| if [[ $(${KUBECTL_BINARY} get ssp -n ${INSTALLED_NAMESPACE}) ]]; then | |||
| [[ $(${KUBECTL_BINARY} get imageStream centos8 -n ${IMAGES_NS} --no-headers | wc -l) -eq 0 ]] | |||
There was a problem hiding this comment.
if you use get for a specific object by name, why counting the output lines and comparing to 0?
whether it's exist, or not.
you can simplify with
[[ ! $(${KUBECTL_BINARY} get imageStream centos8 -n ${IMAGES_NS} ]]
| # Test DataImportCronTemplates | ||
| ./hack/retry.sh 10 3 "${KUBECTL_BINARY} patch hco -n \"${INSTALLED_NAMESPACE}\" --type=json kubevirt-hyperconverged -p '[{ \"op\": \"replace\", \"path\": \"/spec/featureGates/enableCommonBootImageImport\", \"value\": true }]'" | ||
| sleep 10 | ||
|
|
||
| # Test image streams | ||
| [[ $(${KUBECTL_BINARY} get imageStream centos8 -n ${IMAGES_NS} --no-headers | wc -l) -eq 1 ]] |
There was a problem hiding this comment.
same here (opposite logic)
| crType: "ImageStream", | ||
| // Previous versions used to have HCO-operator (scope namespace) | ||
| // as the owner of NetworkAddons (scope cluster). | ||
| // It's not legal, so remove that. |
There was a problem hiding this comment.
this comment doesn't seem relevant here
If the enableCommonBootImageImport FG is set, create the imageStreams and reconcile them
If the enableCommonBootImageImport FG is not set, remove the imageStreams
Signed-off-by: Nahshon Unna-Tsameret nunnatsa@redhat.com
Reviewer Checklist
Release note: