Expose a knob to tune UninstallStrategy #1672

tiraboschi · 2021-12-22T13:31:16Z

Kubevirt and CDI operator were already exposing
a knob to tune the uninstall behaviour when
workloads (VirtualMachines and DataVolumes) still
exists.
The two alternatives are:

BlockUninstallIfWorkloadsExist
RemoveWorkloads

HCO wasn't exposing it always hardocding BlockUninstallIfWorkloadsExist
but RemoveWorkloads can also be an interesting option
for users that wants to cascading drop all
the workloads on product removal.

The defaut behaviour will remain BlockUninstallIfWorkloadsExist

In the futere we can probably implement a better mechanism
like kubernetes/enhancements#2840
but this is still in the design phase.

Signed-off-by: Simone Tiraboschi stirabos@redhat.com

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

Release note:

Expose a knob to tune UninstallStrategy

API changes: add the new uninstallStrategy field; the two supported values are "BlockUninstallIfWorkloadsExist" (default) and "RemoveWorkloads"

tiraboschi · 2021-12-22T17:31:34Z

/retest

coveralls · 2021-12-22T17:36:11Z

Pull Request Test Coverage Report for Build 1615126860

8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 70.612%

Totals
Change from base Build 1612648867:	0.03%
Covered Lines:	3717
Relevant Lines:	5264

💛 - Coveralls

hco-bot · 2021-12-22T18:52:17Z

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure

kubevirt-bot · 2021-12-22T18:52:22Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp, ci/prow/hco-e2e-upgrade-index-azure

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2021-12-22T21:23:16Z

/override-bot

hco-bot · 2021-12-22T21:23:44Z

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp
hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

kubevirt-bot · 2021-12-22T21:23:49Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-aws, ci/prow/hco-e2e-kv-smoke-gcp

In response to this:

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp
hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2021-12-22T21:24:00Z

/retest

docs/cluster-configuration.md

Kubevirt and CDI operator were already exposing a knob to tune the uninstall behaviour when workloads (VirtualMachines and DataVolumes) still exists. The two alternatives are: - BlockUninstallIfWorkloadsExist - RemoveWorkloads HCO wasn't exposing it always hardocding BlockUninstallIfWorkloadsExist but RemoveWorkloads can also be an interesting option for users that wants to cascading drop all the workloads on product removal. The defaut behaviour will remain BlockUninstallIfWorkloadsExist In the futere we can probably implement a better mechanism like kubernetes/enhancements#2840 but this is still in the design phase. Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

sonarcloud · 2021-12-23T10:18:09Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

hco-bot · 2021-12-23T11:35:04Z

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

kubevirt-bot · 2021-12-23T11:35:06Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-12-23T11:53:53Z

hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws

kubevirt-bot · 2021-12-23T11:53:55Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-sno-aws

In response to this:

hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-12-23T12:18:29Z

hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure

kubevirt-bot · 2021-12-23T12:18:32Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-azure

In response to this:

hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa

/approve

kubevirt-bot · 2021-12-23T12:38:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [nunnatsa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2021-12-23T13:22:27Z

@tiraboschi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hco-e2e-image-index-gcp	`6070e51`	link	true	`/test hco-e2e-image-index-gcp`
ci/prow/hco-e2e-upgrade-prev-index-sno-aws	`6070e51`	link	false	`/test hco-e2e-upgrade-prev-index-sno-aws`
ci/prow/hco-e2e-upgrade-index-azure	`6070e51`	link	true	`/test hco-e2e-upgrade-index-azure`
ci/prow/hco-e2e-kv-smoke-gcp	`6070e51`	link	true	`/test hco-e2e-kv-smoke-gcp`
ci/prow/hco-e2e-upgrade-index-sno-aws	`6070e51`	link	false	`/test hco-e2e-upgrade-index-sno-aws`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

hco-bot · 2021-12-23T13:38:28Z

hco-e2e-upgrade-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-aws
hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

kubevirt-bot · 2021-12-23T13:38:31Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp, ci/prow/hco-e2e-upgrade-index-sno-aws

In response to this:

hco-e2e-upgrade-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-aws
hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi requested a review from nunnatsa December 22, 2021 13:31

kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 22, 2021

kubevirt-bot requested review from erkanerol and orenc1 December 22, 2021 13:31

kubevirt-bot added the size/L label Dec 22, 2021

nunnatsa reviewed Dec 23, 2021

View reviewed changes

docs/cluster-configuration.md Show resolved Hide resolved

tiraboschi force-pushed the uninstall_knob branch from 09d8544 to 6070e51 Compare December 23, 2021 10:17

nunnatsa approved these changes Dec 23, 2021

View reviewed changes

kubevirt-bot assigned nunnatsa Dec 23, 2021

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 23, 2021

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 23, 2021

kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 23, 2021

kubevirt-bot merged commit 61028e7 into kubevirt:main Dec 23, 2021

tiraboschi deleted the uninstall_knob branch December 23, 2021 14:13

machadovilaca mentioned this pull request Aug 23, 2023

Dynamically configure CSV disable-operand-delete annotation #2490

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Expose a knob to tune UninstallStrategy #1672

Expose a knob to tune UninstallStrategy #1672

tiraboschi commented Dec 22, 2021 •

edited by nunnatsa

Loading

tiraboschi commented Dec 22, 2021

coveralls commented Dec 22, 2021 •

edited

Loading

hco-bot commented Dec 22, 2021

kubevirt-bot commented Dec 22, 2021

tiraboschi commented Dec 22, 2021

hco-bot commented Dec 22, 2021

kubevirt-bot commented Dec 22, 2021

tiraboschi commented Dec 22, 2021

sonarcloud bot commented Dec 23, 2021

hco-bot commented Dec 23, 2021

kubevirt-bot commented Dec 23, 2021

hco-bot commented Dec 23, 2021

kubevirt-bot commented Dec 23, 2021

hco-bot commented Dec 23, 2021

kubevirt-bot commented Dec 23, 2021

nunnatsa left a comment

kubevirt-bot commented Dec 23, 2021

openshift-ci bot commented Dec 23, 2021

hco-bot commented Dec 23, 2021

kubevirt-bot commented Dec 23, 2021

Expose a knob to tune UninstallStrategy #1672

Expose a knob to tune UninstallStrategy #1672

Conversation

tiraboschi commented Dec 22, 2021 • edited by nunnatsa Loading

tiraboschi commented Dec 22, 2021

coveralls commented Dec 22, 2021 • edited Loading

Pull Request Test Coverage Report for Build 1615126860

💛 - Coveralls

hco-bot commented Dec 22, 2021

kubevirt-bot commented Dec 22, 2021

tiraboschi commented Dec 22, 2021

hco-bot commented Dec 22, 2021

kubevirt-bot commented Dec 22, 2021

tiraboschi commented Dec 22, 2021

sonarcloud bot commented Dec 23, 2021

hco-bot commented Dec 23, 2021

kubevirt-bot commented Dec 23, 2021

hco-bot commented Dec 23, 2021

kubevirt-bot commented Dec 23, 2021

hco-bot commented Dec 23, 2021

kubevirt-bot commented Dec 23, 2021

nunnatsa left a comment

Choose a reason for hiding this comment

kubevirt-bot commented Dec 23, 2021

openshift-ci bot commented Dec 23, 2021

hco-bot commented Dec 23, 2021

kubevirt-bot commented Dec 23, 2021

tiraboschi commented Dec 22, 2021 •

edited by nunnatsa

Loading

coveralls commented Dec 22, 2021 •

edited

Loading