Expand the mediatedDevicesConfiguration API #1688

vladikr · 2022-01-06T21:24:26Z

This PR is a follow up to KubeVirt's kubevirt/kubevirt#6345

This will allow expanding the existing mediatedDevicesConfiguration API to override the mediated devices configuration for a specific node.
Node-specific configuration will be applied in case all NodeSelectors match the node.

Example of the expanded API:

spec:
  configuration:
    mediatedDevicesConfiguration:
      mediatedDevicesTypes:
        - nvidia-222
        - nvidia-228
        - i915-GVTg_V5_4
      nodeMediatedDeviceTypes:
      - nodeSelector:
        someLabel1: ""
        mediatedDevicesTypes:
        - nvidia-222
      - nodeSelector:
        kubernetes.io/hostname=nodeName
        mediatedDevicesTypes:
        - nvidia-228

Release note:
-->

It is now possible to provide a node-specific configuration of the mediated devices types

vladikr · 2022-01-06T21:34:27Z

@nunnatsa @tiraboschi how can i update the KubeVirt API types?

nunnatsa · 2022-01-06T22:14:09Z

@vladikr - this is done in #1684

vladikr · 2022-01-06T22:19:27Z

@vladikr - this is done in #1684

@nunnatsa oh, I see, thanks! I'll wait until this is in. :)

coveralls · 2022-01-07T16:59:53Z

Pull Request Test Coverage Report for Build 1686678022

15 of 181 (8.29%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-2.05%) to 68.559%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/hco/v1beta1/zz_generated.deepcopy.go	2	52	3.85%
pkg/apis/hco/v1beta1/zz_generated.openapi.go	0	116	0.0%

Totals
Change from base Build 1686631433:	-2.05%
Covered Lines:	3731
Relevant Lines:	5442

💛 - Coveralls

nunnatsa · 2022-01-07T17:19:02Z

pkg/controller/operands/kubevirt.go

 	}
 }

+func toKvNodeMediatedDevicesConfiguration(hcoNodeMdevTypesConf []hcov1beta1.NodeMediatedDeviceTypesConfig) []kubevirtcorev1.NodeMediatedDeviceTypesConfig {
+	if len(hcoNodeMdevTypesConf) > 0 {
+		nodeMdevTypesConf := make([]kubevirtcorev1.NodeMediatedDeviceTypesConfig, 0, len(hcoNodeMdevTypesConf))


Since we know the final length of the slice, we can maybe make it woth the known size and set the converted values with using the original index instead of using append?

oh, it's only 2 elements.. what's wrong with append? it's pretty valid in go.

This is a legit golang code. But I think that append is mostly for dynamic size slices, and in cases like this, I prefer direct assignment by the slice index. But that me and I won't block the PR for that (-:

nunnatsa

Thanks for the PR. Can you also run deepcopy and openapi gen? If not, I can help with it.

vladikr · 2022-01-07T17:26:47Z

Thanks for the PR. Can you also run deepcopy and openapi gen? If not, I can help with it.

I'm happy to do it, I just don't know how... maybe you can point me to what should I run?

hco-bot · 2022-01-07T20:12:42Z

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

kubevirt-bot · 2022-01-07T20:12:45Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp

In response to this:

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2022-01-09T17:01:05Z

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

kubevirt-bot · 2022-01-09T17:01:07Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp

In response to this:

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vladikr · 2022-01-10T22:00:23Z

/retest

vladikr · 2022-01-11T15:00:47Z

@nunnatsa I'm not sure why some of the e2e-image tests are failing. Could you please point me to what should I look at to debug this?

nunnatsa · 2022-01-12T08:41:27Z

/rebase

hco-bot · 2022-01-12T10:07:43Z

hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws
okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp
hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp

kubevirt-bot · 2022-01-12T10:07:46Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp, ci/prow/hco-e2e-upgrade-prev-index-sno-aws, ci/prow/okd-hco-e2e-upgrade-index-gcp

In response to this:

hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws
okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp
hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…ration. Signed-off-by: Vladik Romanovsky <vromanso@redhat.com>

sonarcloud · 2022-01-12T10:48:36Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

nunnatsa · 2022-01-12T12:04:36Z

/retest

nunnatsa · 2022-01-12T12:32:19Z

/retest

nunnatsa · 2022-01-12T12:51:23Z

/test hco-e2e-image-index-azure

kubevirt-bot · 2022-01-12T12:51:24Z

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build-hco-test-utils-image
/test pull-hyperconverged-cluster-operator-e2e-k8s-1.21

Use /test all to run the following jobs that were automatically triggered:

pull-hyperconverged-cluster-operator-e2e-k8s-1.21

In response to this:

/test hco-e2e-image-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa · 2022-01-12T13:46:09Z

/override-bot

hco-bot · 2022-01-12T13:46:38Z

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp
hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure
hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws

kubevirt-bot · 2022-01-12T13:46:43Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp, ci/prow/hco-e2e-upgrade-index-azure, ci/prow/hco-e2e-upgrade-prev-index-sno-aws

In response to this:

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp
hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure
hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2022-01-12T14:11:17Z

okd-hco-e2e-upgrade-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-aws

kubevirt-bot · 2022-01-12T14:11:21Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-upgrade-index-aws

In response to this:

okd-hco-e2e-upgrade-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-01-12T14:42:15Z

@vladikr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hco-e2e-image-index-gcp	`1fe35ce`	link	true	`/test hco-e2e-image-index-gcp`
ci/prow/hco-e2e-kv-smoke-gcp	`1fe35ce`	link	true	`/test hco-e2e-kv-smoke-gcp`
ci/prow/okd-hco-e2e-upgrade-index-aws	`1fe35ce`	link	true	`/test okd-hco-e2e-upgrade-index-aws`
ci/prow/hco-e2e-upgrade-prev-index-sno-aws	`1fe35ce`	link	false	`/test hco-e2e-upgrade-prev-index-sno-aws`
ci/prow/hco-e2e-image-index-sno-aws	`1fe35ce`	link	false	`/test hco-e2e-image-index-sno-aws`
ci/prow/hco-e2e-image-index-azure	`1fe35ce`	link	true	`/test hco-e2e-image-index-azure`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

nunnatsa · 2022-01-12T14:57:38Z

/override-bot

nunnatsa · 2022-01-12T15:26:49Z

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure
/override ci/prow/hco-e2e-image-index-gcp

kubevirt-bot · 2022-01-12T15:26:56Z

@nunnatsa: Overrode contexts on behalf of nunnatsa: ci/prow/hco-e2e-image-index-azure, ci/prow/hco-e2e-image-index-gcp

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa · 2022-01-12T15:28:13Z

hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

hco-e2e-upgrade-prev-index-sno-azure succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws

kubevirt-bot · 2022-01-12T15:28:20Z

@nunnatsa: Overrode contexts on behalf of nunnatsa: ci/prow/hco-e2e-image-index-sno-aws, ci/prow/hco-e2e-upgrade-prev-index-sno-aws

In response to this:

hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

hco-e2e-upgrade-prev-index-sno-azure succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa · 2022-01-12T15:28:27Z

/lgtm
/approve

kubevirt-bot · 2022-01-12T15:28:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [nunnatsa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 6, 2022

kubevirt-bot requested review from orenc1 and tiraboschi January 6, 2022 21:24

kubevirt-bot added the size/L label Jan 6, 2022

vladikr force-pushed the mdev_auto_conf_ext branch 2 times, most recently from 7b64fda to a96623b Compare January 7, 2022 16:55

nunnatsa reviewed Jan 7, 2022

View reviewed changes

hco-bot force-pushed the mdev_auto_conf_ext branch from 2ea6cfe to a1475d6 Compare January 12, 2022 08:44

nunnatsa force-pushed the mdev_auto_conf_ext branch from a1475d6 to d78f012 Compare January 12, 2022 10:08

Expand the mediatedDevicesConfiguration API to allow per-node configu…

1fe35ce

…ration. Signed-off-by: Vladik Romanovsky <vromanso@redhat.com>

nunnatsa force-pushed the mdev_auto_conf_ext branch from d78f012 to 1fe35ce Compare January 12, 2022 10:47

kubevirt-bot assigned nunnatsa Jan 12, 2022

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2022

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2022

kubevirt-bot merged commit 2686666 into kubevirt:main Jan 12, 2022

Expand the mediatedDevicesConfiguration API #1688

Expand the mediatedDevicesConfiguration API #1688

Conversation

vladikr commented Jan 6, 2022 • edited Loading

vladikr commented Jan 6, 2022

nunnatsa commented Jan 6, 2022

vladikr commented Jan 6, 2022

coveralls commented Jan 7, 2022 • edited Loading

Pull Request Test Coverage Report for Build 1686678022

💛 - Coveralls

nunnatsa Jan 7, 2022

Choose a reason for hiding this comment

vladikr Jan 7, 2022

Choose a reason for hiding this comment

nunnatsa Jan 9, 2022

Choose a reason for hiding this comment

nunnatsa left a comment

Choose a reason for hiding this comment

vladikr commented Jan 7, 2022

hco-bot commented Jan 7, 2022

kubevirt-bot commented Jan 7, 2022

hco-bot commented Jan 9, 2022

kubevirt-bot commented Jan 9, 2022

vladikr commented Jan 10, 2022

vladikr commented Jan 11, 2022

nunnatsa commented Jan 12, 2022

hco-bot commented Jan 12, 2022

kubevirt-bot commented Jan 12, 2022

sonarcloud bot commented Jan 12, 2022

nunnatsa commented Jan 12, 2022

nunnatsa commented Jan 12, 2022

nunnatsa commented Jan 12, 2022

kubevirt-bot commented Jan 12, 2022

nunnatsa commented Jan 12, 2022

hco-bot commented Jan 12, 2022

kubevirt-bot commented Jan 12, 2022

hco-bot commented Jan 12, 2022

kubevirt-bot commented Jan 12, 2022

openshift-ci bot commented Jan 12, 2022

nunnatsa commented Jan 12, 2022

nunnatsa commented Jan 12, 2022

kubevirt-bot commented Jan 12, 2022

nunnatsa commented Jan 12, 2022

kubevirt-bot commented Jan 12, 2022

nunnatsa commented Jan 12, 2022

kubevirt-bot commented Jan 12, 2022

vladikr commented Jan 6, 2022 •

edited

Loading

coveralls commented Jan 7, 2022 •

edited

Loading