remove centos 8 dataImportCron, because it is EOL #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add centos Stream 8, 9 dataImportCron Signed-off-by: Karel Šimon <ksimon@redhat.com>
kubevirt-bot
added
release-note
|
Kudos, SonarCloud Quality Gate passed!
|
Pull Request Test Coverage Report for Build 1666972237
💛 - Coveralls |
|
looks good. |
tiraboschi
approved these changes
Jan 7, 2022
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tiraboschi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
@tiraboschi can this PR be backported to 4.10? |
|
we have still to branch out so it's implicitly there |
tiraboschi
added a commit
to tiraboschi/hyperconverged-cluster-operator
that referenced
this pull request
Jan 10, 2022
PR kubevirt#1690 removed centos 8 dataImportCron, because it's EOL. Replace it with centos Stream 9 dataImportCron in the tests. Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
11 tasks
tiraboschi
added a commit
to tiraboschi/hyperconverged-cluster-operator
that referenced
this pull request
Jan 10, 2022
1. PR kubevirt#1690 removed centos 8 dataImportCron, because it's EOL. Replace it with centos Stream 9 dataImportCron in the tests. 2. enableCommonBootImageImport is often preventing the product from being correctly uninstalled and this is making CI pretty flaky. Let's explicitly disable it before trying to uninstall on CI until we get a proper fix. See: https://bugzilla.redhat.com/show_bug.cgi?id=2037312 Combine the two fixes in a single PR to unlock CI Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
11 tasks
tiraboschi
added a commit
to tiraboschi/hyperconverged-cluster-operator
that referenced
this pull request
Jan 11, 2022
1. PR kubevirt#1690 removed centos 8 dataImportCron, because it's EOL. Fix the e2e tests accordingly. 2. enableCommonBootImageImport is often preventing the product from being correctly uninstalled and this is making CI pretty flaky. Let's explicitly disable it before trying to uninstall on CI until we get a proper fix. See: https://bugzilla.redhat.com/show_bug.cgi?id=2037312 Combine the two fixes in a single PR to unlock CI Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
kubevirt-bot
pushed a commit
that referenced
this pull request
Jan 12, 2022
…1697) 1. PR #1690 removed centos 8 dataImportCron, because it's EOL. Fix the e2e tests accordingly. 2. enableCommonBootImageImport is often preventing the product from being correctly uninstalled and this is making CI pretty flaky. Let's explicitly disable it before trying to uninstall on CI until we get a proper fix. See: https://bugzilla.redhat.com/show_bug.cgi?id=2037312 Combine the two fixes in a single PR to unlock CI Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove centos 8 dataImportCron, because it is EOL
add centos Stream 8, 9 dataImportCron
This PR kubevirt/containerdisks#12 has to be merged before
/cc @dominikholler
Reviewer Checklist
Release note:
Signed-off-by: Karel Šimon ksimon@redhat.com