Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update configmaps of dashboards #1762

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Update configmaps of dashboards #1762

merged 1 commit into from
Mar 1, 2022

Conversation

hco-bot
Copy link
Collaborator

@hco-bot hco-bot commented Jan 31, 2022

Update configmaps of dashboards

Update configmaps of dashboards

@kubevirt-bot kubevirt-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 31, 2022
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jan 31, 2022
@coveralls
Copy link
Collaborator

coveralls commented Jan 31, 2022 •
edited

Pull Request Test Coverage Report for Build 1886964230

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.216%
Totals Coverage Status
Change from base Build 1886923927: 0.0%
Covered Lines: 3689
Relevant Lines: 4329
💛 - Coveralls

@sradco
Copy link
Collaborator

sradco commented Jan 31, 2022

/assign @machadovilaca

@hco-bot
Copy link
Collaborator Author

hco-bot commented Jan 31, 2022

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

machadovilaca
machadovilaca requested changes Jan 31, 2022
View reviewed changes
Copy link
Member

@machadovilaca machadovilaca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good, just check the missing {
I nitpicked some spacing issues, but there are a few more around operators like )+ irate, but since this is from grafana feel free not to address them

assets/dashboards/grafana-dashboard-kubevirt-top-consumers.yaml Outdated Show resolved Hide resolved
assets/dashboards/grafana-dashboard-kubevirt-top-consumers.yaml Outdated Show resolved Hide resolved
assets/dashboards/grafana-dashboard-kubevirt-top-consumers.yaml Outdated Show resolved Hide resolved
@tiraboschi
Copy link
Member

overall looks good, just check the missing { I nitpicked some spacing issues, but there are a few more around operators like )+ irate, but since this is from grafana feel free not to address them

@machadovilaca in this case the bot simply synced a file from https://github.com/kubevirt/monitoring/blob/main/dashboards/openshift/kubevirt-top-consumers.json

Can you please send your comments on that repo?

/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2022
@erkanerol erkanerol removed their assignment Feb 16, 2022
@erkanerol erkanerol removed their request for review February 16, 2022 07:35
@sradco @web-flow
Update configmaps of dashboards
8a25cd3 
Signed-off-by: HCO Bump Bot <noreply@github.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sradco
Copy link
Collaborator

sradco commented Feb 23, 2022

/retest

@sradco
Copy link
Collaborator

sradco commented Feb 23, 2022

@machadovilaca @tiraboschi Can you please review?
/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2022
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2022
@tiraboschi
Copy link
Member

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2022
@erkanerol erkanerol removed their request for review March 1, 2022 11:02
@erkanerol erkanerol removed their assignment Mar 1, 2022
@tiraboschi
Copy link
Member

/retest

@kubevirt-bot kubevirt-bot merged commit 3a22dcd into main Mar 1, 2022
@sradco
Copy link
Collaborator

sradco commented Mar 2, 2022

@tiraboschi Please backport to 4.10.1

@tiraboschi
Copy link
Member

/cherry-pick release-1.6

@kubevirt-bot kubevirt-bot mentioned this pull request Mar 2, 2022
Merged
@kubevirt-bot
Copy link
Contributor

@tiraboschi: new pull request created: #1803

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiraboschi tiraboschi tiraboschi approved these changes

@machadovilaca machadovilaca machadovilaca approved these changes

Assignees

@tiraboschi tiraboschi

@machadovilaca machadovilaca

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@hco-bot @coveralls @sradco @kubevirt-bot @tiraboschi @machadovilaca @erkanerol