Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release 1.6] Set the CDI version to v1.43.2 #1786

Merged
merged 1 commit into from
Feb 16, 2022
Merged

[Release 1.6] Set the CDI version to v1.43.2 #1786

merged 1 commit into from
Feb 16, 2022

Conversation

nunnatsa
Copy link
Collaborator

@nunnatsa nunnatsa commented Feb 16, 2022 •
edited

The CDI version for release 1.6 should be v1.43.x

This version should contain a fix to a golden images issue.

Signed-off-by: Nahshon Unna-Tsameret nunnatsa@redhat.com

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

  • PR Message
  • Commit Messages
  • How to test
  • Unit Tests
  • Functional Tests
  • User Documentation
  • Developer Documentation
  • Upgrade Scenario
  • Uninstallation Scenario
  • Backward Compatibility
  • Troubleshooting Friendly

Release note:

Set the CDI version to v1.43.2

@nunnatsa
[Release 1.6] Set the CDI version to v1.43.2
4173a92 
This version should contain a fix to a golden images issue.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Feb 16, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nunnatsa nunnatsa mentioned this pull request Feb 16, 2022
Closed
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 1851644226

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.32%
Totals Coverage Status
Change from base Build 1845173860: 0.0%
Covered Lines: 3621
Relevant Lines: 4244
💛 - Coveralls

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2022
@nunnatsa
Copy link
Collaborator Author

/test hco-e2e-upgrade-index-azure

@kubevirt-bot
Copy link
Contributor

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build-hco-test-utils-image
  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.21

Use /test all to run the following jobs that were automatically triggered:

  • pull-hyperconverged-cluster-operator-e2e-k8s-1.21

In response to this:

/test hco-e2e-upgrade-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Collaborator

hco-bot commented Feb 16, 2022

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Feb 16, 2022

@nunnatsa: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hco-e2e-image-index-azure 4173a92 link true /test hco-e2e-image-index-azure
ci/prow/hco-e2e-upgrade-index-azure 4173a92 link true /test hco-e2e-upgrade-index-azure
ci/prow/hco-e2e-upgrade-index-aws 4173a92 link true /test hco-e2e-upgrade-index-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nunnatsa
Copy link
Collaborator Author

/override ci/prow/hco-e2e-upgrade-index-aws
/ovrride ci/prow/hco-e2e-upgrade-index-azure

upgrade test can't work because CDI can't update the version to older one.

@kubevirt-bot
Copy link
Contributor

@nunnatsa: Overrode contexts on behalf of nunnatsa: ci/prow/hco-e2e-upgrade-index-aws

In response to this:

/override ci/prow/hco-e2e-upgrade-index-aws
/ovrride ci/prow/hco-e2e-upgrade-index-azure

upgrade test can't work because CDI can't update the version to older one.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@orenc1
Copy link
Collaborator

orenc1 commented Feb 16, 2022

/override ci/prow/hco-e2e-upgrade-index-azure
/approve

@kubevirt-bot
Copy link
Contributor

@orenc1: Overrode contexts on behalf of orenc1: ci/prow/hco-e2e-upgrade-index-azure

In response to this:

/override ci/prow/hco-e2e-upgrade-index-azure
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: orenc1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2022
@kubevirt-bot kubevirt-bot merged commit 8537795 into kubevirt:release-1.6 Feb 16, 2022
@nunnatsa nunnatsa deleted the Downgarde_CDI_to_v1.43.2 branch February 16, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orenc1 orenc1 orenc1 approved these changes

@tiraboschi tiraboschi Awaiting requested review from tiraboschi

Assignees

@orenc1 orenc1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nunnatsa @coveralls @kubevirt-bot @hco-bot @orenc1