Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manually Bump NETWORK_ADDONS to version v0.67.0 #1790

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Manually Bump NETWORK_ADDONS to version v0.67.0 #1790

merged 1 commit into from
Feb 23, 2022

Conversation

nunnatsa
Copy link
Collaborator

Need to manually bump the version because AddToScheme moved from github.com/kubevirt/cluster-network-addons-operator/pkg/apis to github.com/kubevirt/cluster-network-addons-operator/pkg/apis/networkaddonsoperator/v1, so manual code changes are needed

Signed-off-by: Nahshon Unna-Tsameret nunnatsa@redhat.com

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

  • PR Message
  • Commit Messages
  • How to test
  • Unit Tests
  • Functional Tests
  • User Documentation
  • Developer Documentation
  • Upgrade Scenario
  • Uninstallation Scenario
  • Backward Compatibility
  • Troubleshooting Friendly

Release note:

Bump NETWORK_ADDONS to version v0.67.0

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Feb 22, 2022
@nunnatsa nunnatsa removed the request for review from sradco February 22, 2022 08:33
@nunnatsa nunnatsa requested a review from orenc1 February 22, 2022 08:34
@coveralls
Copy link
Collaborator

coveralls commented Feb 22, 2022 •
edited

Pull Request Test Coverage Report for Build 1885950430

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.216%
Totals Coverage Status
Change from base Build 1883335151: 0.0%
Covered Lines: 3689
Relevant Lines: 4329
💛 - Coveralls

@hco-bot
Copy link
Collaborator

hco-bot commented Feb 22, 2022

hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

1 similar comment
@hco-bot
Copy link
Collaborator

hco-bot commented Feb 22, 2022

hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

@hco-bot
Copy link
Collaborator

hco-bot commented Feb 22, 2022

hco-e2e-image-index-aws, hco-e2e-image-index-gcp lanes succeeded.
/override ci/prow/hco-e2e-image-index-azure
okd-hco-e2e-upgrade-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-aws
hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

2 similar comments
@hco-bot
Copy link
Collaborator

hco-bot commented Feb 22, 2022

hco-e2e-image-index-aws, hco-e2e-image-index-gcp lanes succeeded.
/override ci/prow/hco-e2e-image-index-azure
okd-hco-e2e-upgrade-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-aws
hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

@hco-bot
Copy link
Collaborator

hco-bot commented Feb 22, 2022

hco-e2e-image-index-aws, hco-e2e-image-index-gcp lanes succeeded.
/override ci/prow/hco-e2e-image-index-azure
okd-hco-e2e-upgrade-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-aws
hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

@nunnatsa
Copy link
Collaborator Author

/retest

@hco-bot
Copy link
Collaborator

hco-bot commented Feb 22, 2022

okd-hco-e2e-upgrade-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-aws
hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws
hco-e2e-image-index-aws, hco-e2e-image-index-gcp lanes succeeded.
/override ci/prow/hco-e2e-image-index-azure

@nunnatsa
Copy link
Collaborator Author

/retest

@nunnatsa
Copy link
Collaborator Author

/override ci/prow/hco-e2e-image-index-sno-aws

@kubevirt-bot
Copy link
Contributor

@nunnatsa: Overrode contexts on behalf of nunnatsa: ci/prow/hco-e2e-image-index-sno-aws

In response to this:

/override ci/prow/hco-e2e-image-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 22, 2022
@nunnatsa
Manually Bump NETWORK_ADDONS to version v0.67.0
330ef25 
Need to manually bump the version because `AddToScheme` moved from `github.com/kubevirt/cluster-network-addons-operator/pkg/apis` to `github.com/kubevirt/cluster-network-addons-operator/pkg/apis/networkaddonsoperator/v1`, so manual code changes are needed

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@nunnatsa nunnatsa force-pushed the Bump_NETWORK_ADDONS_to_v0.67.0 branch from 52014a9 to 330ef25 Compare February 23, 2022 07:27
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 23, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hco-bot
Copy link
Collaborator

hco-bot commented Feb 23, 2022

hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-aws

In response to this:

hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Collaborator

hco-bot commented Feb 23, 2022

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-azure

In response to this:

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 23, 2022

@nunnatsa: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hco-e2e-image-index-sno-aws 330ef25 link false /test hco-e2e-image-index-sno-aws
ci/prow/hco-e2e-upgrade-prev-index-azure 330ef25 link true /test hco-e2e-upgrade-prev-index-azure
ci/prow/okd-hco-e2e-upgrade-index-aws 330ef25 link true /test okd-hco-e2e-upgrade-index-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hco-bot
Copy link
Collaborator

hco-bot commented Feb 23, 2022

okd-hco-e2e-upgrade-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-aws

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-upgrade-index-aws

In response to this:

okd-hco-e2e-upgrade-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot merged commit f9cb099 into kubevirt:main Feb 23, 2022
@nunnatsa nunnatsa deleted the Bump_NETWORK_ADDONS_to_v0.67.0 branch February 23, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiraboschi tiraboschi tiraboschi approved these changes

@orenc1 orenc1 Awaiting requested review from orenc1

Assignees

@tiraboschi tiraboschi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nunnatsa @coveralls @hco-bot @kubevirt-bot @tiraboschi