Add kube-rbac-proxy image by digest for CNAO #1791

orenc1 · 2022-02-22T08:40:10Z

CNAO is moving to use HTTPS for its metrics service, and uses kube-rbac-proxy to make the service available with SSL.
The kube-rbac-proxy image should be fetched by digest and be added to the related images section in the CSV.

Once kubevirt/cluster-network-addons-operator#1144 will be merged and a new CNAO will be released, the CNAO section will be populated with the new image as well, by consuming its csv-generator with the new --kube-rbac-proxy-image argument.

Signed-off-by: orenc1 ocohen@redhat.com

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

Release note:

Add kube-rbac-proxy image for CNAO

coveralls · 2022-02-22T08:47:21Z

Pull Request Test Coverage Report for Build 1905549936

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 85.216%

Totals
Change from base Build 1905540550:	0.0%
Covered Lines:	3689
Relevant Lines:	4329

💛 - Coveralls

oshoval

Thanks Oren
Will update once the CNAO is updated

hack/config

oshoval

Thanks
lgtm, lets just be sure it is on hold until CNAO PR is merged

orenc1 · 2022-02-22T09:18:18Z

Thanks lgtm, lets just be sure it is on hold until CNAO PR is merged

I think these are independent.
We can merge this PR, in parallel you merge yours, and then CNAO makes a release that includes this PR.
When new CNAO is released, the bump-bot will run and update the manifests with the new CNAO csv-generator and will open a new PR.

oshoval · 2022-02-22T09:22:11Z

Thanks lgtm, lets just be sure it is on hold until CNAO PR is merged

I think these are independent. We can merge this PR, in parallel you merge yours, and then CNAO makes a release that includes this PR. When new CNAO is released, the bump-bot will run and update the manifests with the new CNAO csv-generator and will open a new PR.

But what if there will be a CNAO release without my code after you merge this PR?
in case the variable will be just disregarded it is fine, but in case the csv-generator would deny it (i.e unknown arg), it will fail isn't it ?

orenc1 · 2022-02-22T09:32:12Z

Thanks lgtm, lets just be sure it is on hold until CNAO PR is merged

I think these are independent. We can merge this PR, in parallel you merge yours, and then CNAO makes a release that includes this PR. When new CNAO is released, the bump-bot will run and update the manifests with the new CNAO csv-generator and will open a new PR.

But what if there will be a CNAO release without my code after you merge this PR? in case the variable will be just disregarded it is fine, but in case the csv-generator would deny it (i.e unknown arg), it will fail isn't it ?

So to be on the safe side, please don't make a new CNAO release without kubevirt/cluster-network-addons-operator#1144. I see the last release was made 5 days ago anyway.
/FYI @phoracek

oshoval · 2022-02-22T09:35:48Z

Thanks lgtm, lets just be sure it is on hold until CNAO PR is merged

I think these are independent. We can merge this PR, in parallel you merge yours, and then CNAO makes a release that includes this PR. When new CNAO is released, the bump-bot will run and update the manifests with the new CNAO csv-generator and will open a new PR.

But what if there will be a CNAO release without my code after you merge this PR? in case the variable will be just disregarded it is fine, but in case the csv-generator would deny it (i.e unknown arg), it will fail isn't it ?

So to be on the safe side, please don't make a new CNAO release without kubevirt/cluster-network-addons-operator#1144. I see the last release was made 5 days ago anyway. /FYI @phoracek

/FYI @qinqon

hco-bot · 2022-02-22T10:34:18Z

okd-hco-e2e-upgrade-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-aws
hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-aws
hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

hco-bot · 2022-02-22T10:44:29Z

hco-e2e-upgrade-prev-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-aws
hco-e2e-image-index-azure, hco-e2e-image-index-gcp lanes succeeded.
/override ci/prow/hco-e2e-image-index-aws
okd-hco-e2e-upgrade-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-aws
hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

hco-bot · 2022-02-22T10:54:01Z

hco-e2e-upgrade-prev-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-aws
hco-e2e-image-index-azure, hco-e2e-image-index-gcp lanes succeeded.
/override ci/prow/hco-e2e-image-index-aws
okd-hco-e2e-upgrade-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-aws
hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

orenc1 · 2022-02-22T11:16:13Z

it would be better to verify all of the changes in the same PR.
waiting for new CNAO release that includes kubevirt/cluster-network-addons-operator#1144, then I'll update the PR with the new CNAO version and re-build the manifests.
/hold

orenc1 · 2022-02-23T11:16:27Z

/retest

orenc1 · 2022-02-23T15:47:50Z

looks like a problem with the bundle resolution/unpacking - InstallPlan wasn't created.
/retest

orenc1 · 2022-02-23T22:13:50Z

/retest

CNAO is moving to use HTTPS for its metrics service, and uses kube-rbac-proxy to make the service available with SSL. The kube-rbac-proxy image should be fetched by digest and be added to the related images section in the CSV. Signed-off-by: orenc1 <ocohen@redhat.com>

sonarcloud · 2022-02-27T08:21:17Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

orenc1 · 2022-02-27T11:48:55Z

/retest

orenc1 · 2022-02-27T13:18:42Z

/retest

openshift-ci · 2022-02-27T16:07:54Z

@orenc1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hco-e2e-upgrade-index-sno-azure	`6dfddb3`	link	false	`/test hco-e2e-upgrade-index-sno-azure`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

orenc1 · 2022-02-27T17:46:09Z

/unhold

hco-bot · 2022-02-27T17:53:59Z

hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure

kubevirt-bot · 2022-02-27T17:54:04Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-sno-azure

In response to this:

hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa · 2022-02-28T06:10:32Z

hack/config

@@ -12,6 +12,7 @@ NODE_DRIVER_REG_VERSION="v2.2.0"
 LIVENESS_PROBE_VERSION="v2.3.0"
 CSI_SNAPSHOT_VERSION="v4.2.1"
 CSI_SIG_STORAGE_PROVISIONER_VERSION="v2.2.1"
+KUBE_RBAC_PROXY_VERSION="4.10"


@orenc1, Do you want to add it to the auto-bump bot?

Not sure it is required. We explicitly specified only the y-stream version, so that we'll get automatic z-stream updates to the image.
We'll update this image tag once in a release.

I think we need to update to 4.11 now ?

nunnatsa · 2022-03-01T07:18:26Z

/lgtm
/approve

kubevirt-bot · 2022-03-01T07:18:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [nunnatsa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

oshoval reviewed Feb 22, 2022

View reviewed changes

hack/config Outdated Show resolved Hide resolved

orenc1 force-pushed the cnao_kube_rbac_proxy branch from 4997a09 to 2580137 Compare February 22, 2022 09:04

oshoval reviewed Feb 22, 2022

View reviewed changes

orenc1 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2022

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 22, 2022

oshoval mentioned this pull request Feb 23, 2022

metrics: Use https instead of http kubevirt/cluster-network-addons-operator#1144

Merged

orenc1 force-pushed the cnao_kube_rbac_proxy branch from 2580137 to d0daf24 Compare February 23, 2022 09:52

kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 23, 2022

orenc1 force-pushed the cnao_kube_rbac_proxy branch from d0daf24 to c83ebce Compare February 23, 2022 11:31

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 24, 2022

orenc1 force-pushed the cnao_kube_rbac_proxy branch from c83ebce to 6dfddb3 Compare February 27, 2022 08:20

kubevirt-bot added size/XS and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S labels Feb 27, 2022

kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2022

nunnatsa reviewed Feb 28, 2022

View reviewed changes

kubevirt-bot assigned nunnatsa Mar 1, 2022

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2022

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2022

kubevirt-bot merged commit 408b048 into kubevirt:main Mar 1, 2022

oshoval mentioned this pull request Dec 21, 2022

Add core-dns image by digest for CNAO #2190

Closed

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add kube-rbac-proxy image by digest for CNAO #1791

Add kube-rbac-proxy image by digest for CNAO #1791

orenc1 commented Feb 22, 2022 •

edited

Loading

coveralls commented Feb 22, 2022 •

edited

Loading

oshoval left a comment

oshoval left a comment

orenc1 commented Feb 22, 2022

oshoval commented Feb 22, 2022 •

edited

Loading

orenc1 commented Feb 22, 2022

oshoval commented Feb 22, 2022 •

edited

Loading

hco-bot commented Feb 22, 2022

hco-bot commented Feb 22, 2022

hco-bot commented Feb 22, 2022

orenc1 commented Feb 22, 2022

orenc1 commented Feb 23, 2022

orenc1 commented Feb 23, 2022

orenc1 commented Feb 23, 2022

sonarcloud bot commented Feb 27, 2022

orenc1 commented Feb 27, 2022

orenc1 commented Feb 27, 2022

openshift-ci bot commented Feb 27, 2022

orenc1 commented Feb 27, 2022

hco-bot commented Feb 27, 2022

kubevirt-bot commented Feb 27, 2022

nunnatsa Feb 28, 2022

orenc1 Feb 28, 2022

oshoval Dec 21, 2022

nunnatsa commented Mar 1, 2022

kubevirt-bot commented Mar 1, 2022

Add kube-rbac-proxy image by digest for CNAO #1791

Add kube-rbac-proxy image by digest for CNAO #1791

Conversation

orenc1 commented Feb 22, 2022 • edited Loading

coveralls commented Feb 22, 2022 • edited Loading

Pull Request Test Coverage Report for Build 1905549936

💛 - Coveralls

oshoval left a comment

Choose a reason for hiding this comment

oshoval left a comment

Choose a reason for hiding this comment

orenc1 commented Feb 22, 2022

oshoval commented Feb 22, 2022 • edited Loading

orenc1 commented Feb 22, 2022

oshoval commented Feb 22, 2022 • edited Loading

hco-bot commented Feb 22, 2022

hco-bot commented Feb 22, 2022

hco-bot commented Feb 22, 2022

orenc1 commented Feb 22, 2022

orenc1 commented Feb 23, 2022

orenc1 commented Feb 23, 2022

orenc1 commented Feb 23, 2022

sonarcloud bot commented Feb 27, 2022

orenc1 commented Feb 27, 2022

orenc1 commented Feb 27, 2022

openshift-ci bot commented Feb 27, 2022

orenc1 commented Feb 27, 2022

hco-bot commented Feb 27, 2022

kubevirt-bot commented Feb 27, 2022

nunnatsa Feb 28, 2022

Choose a reason for hiding this comment

orenc1 Feb 28, 2022

Choose a reason for hiding this comment

oshoval Dec 21, 2022

Choose a reason for hiding this comment

nunnatsa commented Mar 1, 2022

kubevirt-bot commented Mar 1, 2022

orenc1 commented Feb 22, 2022 •

edited

Loading

coveralls commented Feb 22, 2022 •

edited

Loading

oshoval commented Feb 22, 2022 •

edited

Loading

oshoval commented Feb 22, 2022 •

edited

Loading