Opt-out from cluster-wide default node selector #1799
Conversation
kubevirt-bot
added
release-note
tiraboschi
force-pushed
the
namespace_node_selector
branch
from
402fa1d
to
2ca2ebc
Compare
Pull Request Test Coverage Report for Build 1969959500
💛 - Coveralls |
tiraboschi
force-pushed
the
namespace_node_selector
branch
from
2ca2ebc
to
2e2086a
Compare
|
/retest |
tiraboschi
force-pushed
the
namespace_node_selector
branch
6 times, most recently
from
17d85d7
to
ff033d2
Compare
|
hco-e2e-image-index-gcp lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-aws, ci/prow/hco-e2e-image-index-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tiraboschi
force-pushed
the
namespace_node_selector
branch
from
ff033d2
to
9431def
Compare
|
hco-e2e-upgrade-prev-index-azure lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tiraboschi
force-pushed
the
namespace_node_selector
branch
from
9431def
to
8257afe
Compare
|
hco-e2e-image-index-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure, ci/prow/hco-e2e-upgrade-prev-index-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override-bot |
|
hco-e2e-upgrade-index-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pkg/controller/operands/namespace.go
Outdated
| if found.Labels == nil { | ||
| found.Labels = make(map[string]string) | ||
| } |
There was a problem hiding this comment.
Couldn't this be made outside the loop? Probably most of the time it would reduce the number of comparisons made.
pkg/controller/operands/namespace.go
Outdated
| if found.Annotations == nil { | ||
| found.Annotations = make(map[string]string) | ||
| } |
| @@ -96,6 +96,7 @@ var _ = Describe("HyperconvergedController", func() { | |||
| }) | |||
|
|
|||
| It("should ignore invalid requests", func() { | |||
| hcoNamespace := commonTestUtils.NewHcoNamespace() | |||
There was a problem hiding this comment.
This is done in many tests, couldn't this namespace be created only once and be reused in all of them?
There was a problem hiding this comment.
in pkg/controller/operands/operandHandler_test.go there's the same issue
|
hco-e2e-kv-smoke-gcp lane succeeded. |
|
okd-hco-e2e-image-index-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-image-index-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold |
kubevirt-bot
added
the
do-not-merge/hold
tiraboschi
force-pushed
the
namespace_node_selector
branch
from
25b588e
to
5a75875
Compare
|
/unhold |
kubevirt-bot
removed
the
do-not-merge/hold
The hyperconverged cluster operator defines its own node selectors APIs that schedules deployments and daemon sets on nodes according to infra and workload classification. Opting out from cluster-wide default node selector on Openshift setting a specific annotation (openshift.io/node-selector=) to prevent conflicts. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2055950 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi
force-pushed
the
namespace_node_selector
branch
from
5a75875
to
206327d
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
hco-e2e-image-index-aws lane succeeded. |
|
hco-e2e-upgrade-prev-index-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure, ci/prow/hco-e2e-image-index-gcp, ci/prow/hco-e2e-upgrade-index-azure, ci/prow/hco-e2e-upgrade-prev-index-azure, ci/prow/hco-e2e-upgrade-prev-index-sno-azure, ci/prow/okd-hco-e2e-image-index-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
@tiraboschi: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
|
/override coverage/coveralls |
|
@tiraboschi: Overrode contexts on behalf of tiraboschi: coverage/coveralls In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| if needUpdate { | ||
| if req.HCOTriggered { | ||
| req.Logger.Info("Updating existing namespace to new opinionated values") | ||
| } else { | ||
| req.Logger.Info("Reconciling an externally updated namespace to its opinionated values") | ||
| } | ||
| err := h.Client.Update(req.Ctx, found) | ||
| if err != nil { | ||
| if err != nil { | ||
| req.Logger.Error(err, "failed updating the namespace") | ||
| return &EnsureResult{ | ||
| Err: err, | ||
| } | ||
| } | ||
| } | ||
| res.SetUpdated() | ||
| res.SetOverwritten(!req.HCOTriggered) | ||
| return res | ||
| } |
There was a problem hiding this comment.
this condition and the needUpdate variable are not needed. it all can be placed in the previous condition. But we can fix it later.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nunnatsa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/cherry-pick release-1.6 |
|
@tiraboschi: #1799 failed to apply on top of branch "release-1.6": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…rt#1799) The hyperconverged cluster operator defines its own node selectors APIs that schedules deployments and daemon sets on nodes according to infra and workload classification. Opting out from cluster-wide default node selector on Openshift setting a specific annotation (openshift.io/node-selector=) to prevent conflicts. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2055950 This is a manual cherry-pick of kubevirt#1799 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
…#1816) The hyperconverged cluster operator defines its own node selectors APIs that schedules deployments and daemon sets on nodes according to infra and workload classification. Opting out from cluster-wide default node selector on Openshift setting a specific annotation (openshift.io/node-selector=) to prevent conflicts. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2055950 This is a manual cherry-pick of #1799 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
The hyperconverged cluster operator defines
its own node selectors APIs that schedules
deployments and daemon sets on nodes according to
infra and workload classification.
Opting out from cluster-wide default node selector
on Openshift setting a specific annotation
(openshift.io/node-selector=) to prevent conflicts.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2055950
Signed-off-by: Simone Tiraboschi stirabos@redhat.com
Reviewer Checklist
Release note: